From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Subject: Re: [PATCH v2 07/11] test: Add nsholder utility
Date: Fri, 09 Sep 2022 17:18:58 +0200 [thread overview]
Message-ID: <20220909171858.7010d6b7@elisabeth> (raw)
In-Reply-To: <20220908014920.1474597-8-david@gibson.dropbear.id.au>
[-- Attachment #1: Type: text/plain, Size: 510 bytes --]
Nit:
On Thu, 8 Sep 2022 11:49:16 +1000
David Gibson <david(a)gibson.dropbear.id.au> wrote:
> [...]
>
> diff --git a/test/nsholder.c b/test/nsholder.c
> new file mode 100644
> index 0000000..bfe3611
> --- /dev/null
> +++ b/test/nsholder.c
> @@ -0,0 +1,117 @@
> +#define _GNU_SOURCE
It would be nice to have a licence and copyright notice here. From my
perspective it's not necessarily needed (it would default to AGPLv3 and
you as copyright holder), but might cause some trouble to packagers.
--
Stefano
next prev parent reply other threads:[~2022-09-09 15:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 1:49 [PATCH v2 00/11] Improve command dispatch in test scripts David Gibson
2022-09-08 1:49 ` [PATCH v2 01/11] test: Correctly match "background" with "wait" commands David Gibson
2022-09-08 1:49 ` [PATCH v2 02/11] test: Context execution helpers David Gibson
2022-09-08 1:49 ` [PATCH v2 03/11] test: Allow a tmux pane to watch commands executed in contexts David Gibson
2022-09-09 15:18 ` Stefano Brivio
2022-09-10 6:36 ` David Gibson
2022-09-08 1:49 ` [PATCH v2 04/11] test: Integration of old-style pane execution and new context execution David Gibson
2022-09-08 1:49 ` [PATCH v2 05/11] test: Issue host commands via context for most tests David Gibson
2022-09-09 15:18 ` Stefano Brivio
2022-09-10 6:38 ` David Gibson
2022-09-08 1:49 ` [PATCH v2 06/11] test: Use new-style contexts for passt pane in the pasta and passt tests David Gibson
2022-09-08 1:49 ` [PATCH v2 07/11] test: Add nsholder utility David Gibson
2022-09-09 15:18 ` Stefano Brivio [this message]
2022-09-10 6:45 ` David Gibson
2022-09-08 1:49 ` [PATCH v2 08/11] test: Extend context system to run commands in namespace for pasta tests David Gibson
2022-09-08 1:49 ` [PATCH v2 09/11] test: Use context system for guest commands David Gibson
2022-09-08 1:49 ` [PATCH v2 10/11] test: Use context system for two_guests tests David Gibson
2022-09-08 1:49 ` [PATCH v2 11/11] test: Use new-style command issue for passt_in_ns tests David Gibson
2022-09-09 15:19 ` Stefano Brivio
2022-09-10 6:47 ` David Gibson
2022-09-10 20:40 ` Stefano Brivio
2022-09-09 15:21 ` [PATCH v2 00/11] Improve command dispatch in test scripts Stefano Brivio
2022-09-10 6:59 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220909171858.7010d6b7@elisabeth \
--to=sbrivio@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).