public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject: [PATCH v5 00/14] Improve handling of test temporary files
Date: Tue, 13 Sep 2022 14:35:15 +1000	[thread overview]
Message-ID: <20220913043529.3079003-1-david@gibson.dropbear.id.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 4348 bytes --]

The tests create temporary files and fifos in a number of places.
Some of them can interfere with later test runs, and are awkward to
clean up.  Consolidate them in a single per-run directory in /tmp
which gets cleaned up automatically.

This is based on the earlier userns cleanup series.

Changes since v4:
 * Also moved .pid files from demo into state directory
 * Moved the .cast video files into $LOGDIR/web instead of plain
   $LOGDIR
 * Added a new patch moving the perf.js report into $LOGDIR/web too
 * Updated hooks/pre-push to take things from their new directories
Changes since v3:
 * Fixed problem with ssh hosts file naming which caused a bunch of
   non-fatal warnings
Changes since v2:
 * Reinstated patch to move the log pipe accidentally dropped during
   a rebase
Chances since v1:
 * Fixed a number of straightforward bugs where things were missed
 * Also removed files we're no longer putting into the source tree
   from .gitignore
 * Added an extra patch moving the video processing files

David Gibson (14):
  test: Group tests by mode then protocol, rather than the reverse
  test: Remove unused variable FFMPEG_PID_FILE
  test: Actually run cleanup function
  test: Create common state directories for temporary files
  test: Move passt_test_log_pipe to state directory
  test: Move context temporary files to state dir
  test: Don't redundantly regenerate small test file in pasta/tcp
  test: Use paths in __STATEDIR__ instead of 'temp' and 'tempdir'
    directives
  test: Move pause temporary file to state directory
  test: Store pcap files in $LOGDIR instead of /tmp
  test: Move pidfiles and nsholder sockets into state directory
  demo: Move pidfiles to state directory
  test: Move video processing files to $STATEBASE
  test: Move perf.js report file to $LOGDIR/web

 .gitignore                                    |  1 -
 hooks/pre-push                                | 12 +--
 test/.gitignore                               |  5 --
 test/build/all                                | 31 ++++---
 test/demo/passt                               | 14 ++--
 test/demo/pasta                               | 20 ++---
 test/demo/podman                              | 11 ++-
 test/distro/debian                            |  2 +-
 test/distro/fedora                            |  2 +-
 test/distro/opensuse                          | 16 ++--
 test/distro/ubuntu                            |  8 +-
 test/lib/context                              | 61 +++++++-------
 test/lib/layout                               | 16 ++--
 test/lib/perf_report                          |  3 +-
 test/lib/setup                                | 84 ++++++++++---------
 test/lib/term                                 | 26 +++---
 test/lib/test                                 | 14 +---
 test/lib/video                                | 38 +++++----
 test/{dhcp/passt => passt/dhcp}               |  2 +-
 test/{ndp/passt => passt/ndp}                 |  2 +-
 test/{shutdown/passt => passt/shutdown}       |  4 +-
 test/{tcp/passt => passt/tcp}                 |  6 +-
 test/{udp/passt => passt/udp}                 |  8 +-
 test/{icmp/passt_in_ns => passt_in_ns/icmp}   |  2 +-
 .../passt_in_ns => passt_in_ns/shutdown}      |  4 +-
 test/{tcp/passt_in_ns => passt_in_ns/tcp}     | 10 +--
 test/{udp/passt_in_ns => passt_in_ns/udp}     |  8 +-
 test/{dhcp/pasta => pasta/dhcp}               |  2 +-
 test/{ndp/pasta => pasta/ndp}                 |  2 +-
 test/{tcp/pasta => pasta/tcp}                 | 13 ++-
 test/{udp/pasta => pasta/udp}                 | 20 ++---
 test/run                                      | 48 +++++------
 32 files changed, 243 insertions(+), 252 deletions(-)
 rename test/{dhcp/passt => passt/dhcp} (98%)
 rename test/{ndp/passt => passt/ndp} (95%)
 rename test/{shutdown/passt => passt/shutdown} (80%)
 rename test/{tcp/passt => passt/tcp} (96%)
 rename test/{udp/passt => passt/udp} (88%)
 rename test/{icmp/passt_in_ns => passt_in_ns/icmp} (94%)
 rename test/{shutdown/passt_in_ns => passt_in_ns/shutdown} (79%)
 rename test/{tcp/passt_in_ns => passt_in_ns/tcp} (97%)
 rename test/{udp/passt_in_ns => passt_in_ns/udp} (97%)
 rename test/{dhcp/pasta => pasta/dhcp} (96%)
 rename test/{ndp/pasta => pasta/ndp} (95%)
 rename test/{tcp/pasta => pasta/tcp} (95%)
 rename test/{udp/pasta => pasta/udp} (74%)

-- 
2.37.3


             reply	other threads:[~2022-09-13  4:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-13  4:35 David Gibson [this message]
2022-09-13  4:35 ` [PATCH v5 01/14] test: Group tests by mode then protocol, rather than the reverse David Gibson
2022-09-13  4:35 ` [PATCH v5 02/14] test: Remove unused variable FFMPEG_PID_FILE David Gibson
2022-09-13  4:35 ` [PATCH v5 03/14] test: Actually run cleanup function David Gibson
2022-09-13  4:35 ` [PATCH v5 04/14] test: Create common state directories for temporary files David Gibson
2022-09-13  4:35 ` [PATCH v5 05/14] test: Move passt_test_log_pipe to state directory David Gibson
2022-09-13  4:35 ` [PATCH v5 06/14] test: Move context temporary files to state dir David Gibson
2022-09-13  4:35 ` [PATCH v5 07/14] test: Don't redundantly regenerate small test file in pasta/tcp David Gibson
2022-09-13  4:35 ` [PATCH v5 08/14] test: Use paths in __STATEDIR__ instead of 'temp' and 'tempdir' directives David Gibson
2022-09-13  4:35 ` [PATCH v5 09/14] test: Move pause temporary file to state directory David Gibson
2022-09-13  4:35 ` [PATCH v5 10/14] test: Store pcap files in $LOGDIR instead of /tmp David Gibson
2022-09-13  4:35 ` [PATCH v5 11/14] test: Move pidfiles and nsholder sockets into state directory David Gibson
2022-09-13  4:35 ` [PATCH v5 12/14] demo: Move pidfiles to " David Gibson
2022-09-13  4:35 ` [PATCH v5 13/14] test: Move video processing files to $STATEBASE David Gibson
2022-09-13  4:35 ` [PATCH v5 14/14] test: Move perf.js report file to $LOGDIR/web David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220913043529.3079003-1-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).