From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject: [PATCH v5 12/14] demo: Move pidfiles to state directory
Date: Tue, 13 Sep 2022 14:35:27 +1000 [thread overview]
Message-ID: <20220913043529.3079003-13-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20220913043529.3079003-1-david@gibson.dropbear.id.au>
[-- Attachment #1: Type: text/plain, Size: 2009 bytes --]
Avoiding putting them in bare /tmp means they will be automatically
cleaned up with everything else.
Signed-off-by: David Gibson <david(a)gibson.dropbear.id.au>
---
test/demo/passt | 5 +++--
test/demo/pasta | 10 +++++-----
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/test/demo/passt b/test/demo/passt
index dd6a119..eb9b856 100644
--- a/test/demo/passt
+++ b/test/demo/passt
@@ -69,7 +69,7 @@ say 'pasta' demo above.
sleep 3
passt cd __STATEDIR__/passt
-passtb ./pasta -P /tmp/pasta.pid
+passtb ./pasta -P pasta.pid
sleep 3
passt /sbin/dhclient -4 --no-pid
sleep 2
@@ -82,7 +82,8 @@ say Now let's run 'passt' in the new namespace, and
nl
say enter this namespace from the guest terminal too.
sleep 3
-gout TARGET_PID pgrep -P $(cat /tmp/pasta.pid)
+guest cd __STATEDIR__/passt
+gout TARGET_PID pgrep -P $(cat pasta.pid)
sleep 1
passtb ./passt -f -t 5201,5203
diff --git a/test/demo/pasta b/test/demo/pasta
index 22479f8..02a2ba2 100644
--- a/test/demo/pasta
+++ b/test/demo/pasta
@@ -47,7 +47,7 @@ nl
say without PID, it will create a namespace.
sleep 3
passt cd __STATEDIR__/passt
-passtb ./pasta -P /tmp/pasta.pid
+passtb ./pasta -P pasta.pid
sleep 3
nl
@@ -56,7 +56,8 @@ say For convenience, let's enter this namespace
nl
say from another terminal.
sleep 3
-nsout TARGET_PID pgrep -P $(cat /tmp/pasta.pid)
+ns cd __STATEDIR__/passt
+nsout TARGET_PID pgrep -P $(cat pasta.pid)
sleep 1
ns nsenter -t __TARGET_PID__ -U -n --preserve-credentials
@@ -168,10 +169,10 @@ passt exit
passt make clean
passt CFLAGS="-g" make
sleep 2
-passtb perf record -g ./pasta -P /tmp/pasta.pid
+passtb perf record -g ./pasta -P pasta.pid
sleep 2
-nsout TARGET_PID pgrep -P $(cat /tmp/pasta.pid)
+nsout TARGET_PID pgrep -P $(cat pasta.pid)
sleep 1
ns nsenter -t __TARGET_PID__ -U -n --preserve-credentials
sleep 5
@@ -255,7 +256,6 @@ sleep 2
killp PASST
killp HOST
sleep 2
-ns cd __STATEDIR__/passt
nsb perf report -g --max-stack 3
sleep 10
--
@@ -47,7 +47,7 @@ nl
say without PID, it will create a namespace.
sleep 3
passt cd __STATEDIR__/passt
-passtb ./pasta -P /tmp/pasta.pid
+passtb ./pasta -P pasta.pid
sleep 3
nl
@@ -56,7 +56,8 @@ say For convenience, let's enter this namespace
nl
say from another terminal.
sleep 3
-nsout TARGET_PID pgrep -P $(cat /tmp/pasta.pid)
+ns cd __STATEDIR__/passt
+nsout TARGET_PID pgrep -P $(cat pasta.pid)
sleep 1
ns nsenter -t __TARGET_PID__ -U -n --preserve-credentials
@@ -168,10 +169,10 @@ passt exit
passt make clean
passt CFLAGS="-g" make
sleep 2
-passtb perf record -g ./pasta -P /tmp/pasta.pid
+passtb perf record -g ./pasta -P pasta.pid
sleep 2
-nsout TARGET_PID pgrep -P $(cat /tmp/pasta.pid)
+nsout TARGET_PID pgrep -P $(cat pasta.pid)
sleep 1
ns nsenter -t __TARGET_PID__ -U -n --preserve-credentials
sleep 5
@@ -255,7 +256,6 @@ sleep 2
killp PASST
killp HOST
sleep 2
-ns cd __STATEDIR__/passt
nsb perf report -g --max-stack 3
sleep 10
--
2.37.3
next prev parent reply other threads:[~2022-09-13 4:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 4:35 [PATCH v5 00/14] Improve handling of test temporary files David Gibson
2022-09-13 4:35 ` [PATCH v5 01/14] test: Group tests by mode then protocol, rather than the reverse David Gibson
2022-09-13 4:35 ` [PATCH v5 02/14] test: Remove unused variable FFMPEG_PID_FILE David Gibson
2022-09-13 4:35 ` [PATCH v5 03/14] test: Actually run cleanup function David Gibson
2022-09-13 4:35 ` [PATCH v5 04/14] test: Create common state directories for temporary files David Gibson
2022-09-13 4:35 ` [PATCH v5 05/14] test: Move passt_test_log_pipe to state directory David Gibson
2022-09-13 4:35 ` [PATCH v5 06/14] test: Move context temporary files to state dir David Gibson
2022-09-13 4:35 ` [PATCH v5 07/14] test: Don't redundantly regenerate small test file in pasta/tcp David Gibson
2022-09-13 4:35 ` [PATCH v5 08/14] test: Use paths in __STATEDIR__ instead of 'temp' and 'tempdir' directives David Gibson
2022-09-13 4:35 ` [PATCH v5 09/14] test: Move pause temporary file to state directory David Gibson
2022-09-13 4:35 ` [PATCH v5 10/14] test: Store pcap files in $LOGDIR instead of /tmp David Gibson
2022-09-13 4:35 ` [PATCH v5 11/14] test: Move pidfiles and nsholder sockets into state directory David Gibson
2022-09-13 4:35 ` David Gibson [this message]
2022-09-13 4:35 ` [PATCH v5 13/14] test: Move video processing files to $STATEBASE David Gibson
2022-09-13 4:35 ` [PATCH v5 14/14] test: Move perf.js report file to $LOGDIR/web David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220913043529.3079003-13-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).