From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH v4 0/8] Don't use additional sockets for receiving "spliced" UDP communications
Date: Thu, 5 Jan 2023 22:50:03 +0100 [thread overview]
Message-ID: <20230105225003.023e4e66@elisabeth> (raw)
In-Reply-To: <20230105042625.1981812-1-david@gibson.dropbear.id.au>
On Thu, 5 Jan 2023 15:26:17 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> At present, the UDP "splice" and "tap" paths are quite separate. We
> have separate sockets to receive packets bound for the tap and splice
> paths. This leads to some code duplication, and extra open sockets.
>
> This series partially unifies the two paths, allowing us to use a
> single (host side) socket, bound to 0.0.0.0 or :: to receive packets
> for both cases.
>
> Changes since v3:
> * Fixed really dumb compile error, and actually ran through the tests.
> Oops.
> Changes since v2:
> * Don't receive multiple packets at once for pasta mode - seems to
> hurt throughput on balance.
> * Add some comments clarifying reasoning here.
> Changes since v1:
> * Renamed udp_localname[46] to udp[46]_localname
> * Allow handling of UDP port 0
> * Fix a bug which could misidentify certain v6 packets as v4-spliceable
> * Some minor cosmetic fixes to code and commit messages
Thanks, this looks good to me now, and I'm trying to run the tests
before applying it, but for some reason they get invariably stuck at
perf/passt_udp in the host to guest throughput test.
I think it has nothing to do with this series, and it's rather related
to the "new" suspected virtio-net TX timeout issue we started hitting a
while ago, I still need to play with kernel version/workarounds etc.
I'll keep you posted.
--
Stefano
next prev parent reply other threads:[~2023-01-05 21:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 4:26 [PATCH v4 0/8] Don't use additional sockets for receiving "spliced" UDP communications David Gibson
2023-01-05 4:26 ` [PATCH v4 1/8] udp: Move sending pasta tap frames to the end of udp_sock_handler() David Gibson
2023-01-05 4:26 ` [PATCH v4 2/8] udp: Split sending to passt tap interface into separate function David Gibson
2023-01-05 4:26 ` [PATCH v4 3/8] udp: Split receive from preparation and send in udp_sock_handler() David Gibson
2023-01-05 4:26 ` [PATCH v4 4/8] udp: Don't handle tap receive batch size calculation within a #define David Gibson
2023-01-05 4:26 ` [PATCH v4 5/8] udp: Pre-populate msg_names with local address David Gibson
2023-01-05 4:26 ` [PATCH v4 6/8] udp: Unify udp_sock_handler_splice() with udp_sock_handler() David Gibson
2023-01-05 4:26 ` [PATCH v4 7/8] udp: Decide whether to "splice" per datagram rather than per socket David Gibson
2023-01-05 4:26 ` [PATCH v4 8/8] udp: Don't use separate sockets to listen for spliced packets David Gibson
2023-01-05 21:50 ` Stefano Brivio [this message]
2023-01-06 0:59 ` [PATCH v4 0/8] Don't use additional sockets for receiving "spliced" UDP communications David Gibson
2023-01-13 0:07 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230105225003.023e4e66@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).