public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>, passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v2 0/4] Some cleanups to tap and tcp
Date: Thu, 16 Feb 2023 16:43:07 +1100	[thread overview]
Message-ID: <20230216054311.2131853-1-david@gibson.dropbear.id.au> (raw)

This is a handful of simple cleanups which I made while investigating
https://bugs.passt.top/show_bug.cgi?id=41.  Note that these don't
themselves actually address that bug, they're just unrelated cleanups
that happen to be in adjacent code.

I've run basic tests on these, but not quite the complete test suite:
I haven't yet had a chance to debug an unrelated problem with the IPv4
performance tests failing.

Changes since v1:
 * Minor comment and style fixes

David Gibson (4):
  tap: Don't pcap frames that didn't get sent
  tap: Eliminate goto from tap_handler()
  tcp: Remove 'recvmsg' goto from tcp_data_from_sock
  tcp: Remove 'zero_len' goto from tcp_data_from_sock

 tap.c | 49 +++++++++++++++++++++++++++----------------------
 tcp.c | 37 +++++++++++++++++--------------------
 2 files changed, 44 insertions(+), 42 deletions(-)

-- 
2.39.1


             reply	other threads:[~2023-02-16  5:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-16  5:43 David Gibson [this message]
2023-02-16  5:43 ` [PATCH v2 1/4] tap: Don't pcap frames that didn't get sent David Gibson
2023-02-16  5:43 ` [PATCH v2 2/4] tap: Eliminate goto from tap_handler() David Gibson
2023-02-16  5:43 ` [PATCH v2 3/4] tcp: Remove 'recvmsg' goto from tcp_data_from_sock David Gibson
2023-02-16  5:43 ` [PATCH v2 4/4] tcp: Remove 'zero_len' " David Gibson
2023-02-16 22:22 ` [PATCH v2 0/4] Some cleanups to tap and tcp Stefano Brivio
2023-02-16 22:55   ` David Gibson
2023-02-17  7:44     ` Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230216054311.2131853-1-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).