From: Stefano Brivio <sbrivio@redhat.com>
To: Michal Privoznik <mprivozn@redhat.com>
Cc: libvir-list@redhat.com, passt-dev@passt.top
Subject: Re: [PATCH v2 1/5] qemu_passt: Avoid double daemonizing passt
Date: Thu, 16 Feb 2023 17:06:50 +0100 [thread overview]
Message-ID: <20230216170650.4da5ed13@elisabeth> (raw)
In-Reply-To: <4fa71e685d69f496d481ef51157c1ffa4c85166d.1676554196.git.mprivozn@redhat.com>
On Thu, 16 Feb 2023 14:32:48 +0100
Michal Privoznik <mprivozn@redhat.com> wrote:
> When passt is started, it daemonizes itself by default. There's
> no point in having our virCommand module daemonize it too.
>
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
> src/qemu/qemu_passt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/src/qemu/qemu_passt.c b/src/qemu/qemu_passt.c
> index 78830fdc26..adc69fc052 100644
> --- a/src/qemu/qemu_passt.c
> +++ b/src/qemu/qemu_passt.c
> @@ -156,7 +156,6 @@ qemuPasstStart(virDomainObj *vm,
> virCommandClearCaps(cmd);
> virCommandSetPidFile(cmd, pidfile);
> virCommandSetErrorFD(cmd, &errfd);
> - virCommandDaemonize(cmd);
>
> virCommandAddArgList(cmd,
> "--one-off",
For what it's worth,
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
--
Stefano
next prev parent reply other threads:[~2023-02-16 16:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 13:32 [PATCH v2 0/5] qemu_passt: Fix issues with PID file Michal Privoznik
2023-02-16 13:32 ` [PATCH v2 1/5] qemu_passt: Avoid double daemonizing passt Michal Privoznik
2023-02-16 16:06 ` Stefano Brivio [this message]
2023-02-16 16:34 ` Laine Stump
2023-02-16 13:32 ` [PATCH v2 2/5] qemu_passt: Report passt's error on failed start Michal Privoznik
2023-02-16 16:06 ` Stefano Brivio
2023-02-16 16:38 ` Laine Stump
2023-02-16 13:32 ` [PATCH v2 3/5] qemu_passt: Make passt report errors to stderr whenever possible Michal Privoznik
2023-02-16 15:42 ` Jonathon Jongsma
2023-02-16 16:21 ` Michal Prívozník
2023-02-16 22:48 ` David Gibson
2023-02-16 16:07 ` Stefano Brivio
2023-02-16 16:27 ` Michal Prívozník
2023-02-16 16:35 ` Stefano Brivio
2023-02-16 16:37 ` Laine Stump
2023-02-16 16:33 ` Laine Stump
2023-02-16 13:32 ` [PATCH v2 4/5] qemu_passt: Deduplicate passt killing code Michal Privoznik
2023-02-16 16:07 ` Stefano Brivio
2023-02-16 16:38 ` Michal Prívozník
2023-02-16 17:05 ` Stefano Brivio
2023-02-16 16:42 ` Laine Stump
2023-02-16 13:32 ` [PATCH v2 5/5] qemu_passt: Let passt write the PID file Michal Privoznik
2023-02-16 16:47 ` Laine Stump
2023-02-16 16:35 ` [PATCH v2 0/5] qemu_passt: Fix issues with " Laine Stump
2023-02-17 12:51 ` Michal Prívozník
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230216170650.4da5ed13@elisabeth \
--to=sbrivio@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mprivozn@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).