From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top, Laurent Vivier <lvivier@redhat.com>
Subject: Re: [PATCH 3/6] util: Add write_remainder() helper
Date: Wed, 28 Feb 2024 10:22:47 +0100 [thread overview]
Message-ID: <20240228102247.63854842@elisabeth> (raw)
In-Reply-To: <Zd73N9GgBIDCEOEP@zatzit>
On Wed, 28 Feb 2024 20:04:55 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> On Wed, Feb 28, 2024 at 07:24:10AM +0100, Stefano Brivio wrote:
> > On Wed, 28 Feb 2024 11:44:28 +1100
> > David Gibson <david@gibson.dropbear.id.au> wrote:
> >
> > > On Tue, Feb 27, 2024 at 03:25:51PM +0100, Stefano Brivio wrote:
> > > > On Thu, 22 Feb 2024 16:55:59 +1100
> > > > David Gibson <david@gibson.dropbear.id.au> wrote:
> > > >
> > > > [...]
> > > >
> > > > > +
> > > > > + if (skip)
> > > >
> > > > Curly brackets here for consistency (undecided about readability to be
> > > > honest).
> > >
> > > Uh.. consistency with what? We don't typically brace single line
> > > clauses in passt.
> > >
> > > > > + rc = write(fd, (char *)iov[i].iov_base + skip,
> > > > > + iov[i].iov_len - skip);
> >
> > These are two lines though. I've been trying to keep this consistent
> > with the Linux kernel's net/ and drivers/net/ style, where curly braces
> > are used for multiple lines, even if it's a single statement.
>
> Ah, fair enough. It never occurred to me to consider physical lines
> rather than logical lines.
>
> Adjust and merge if you want, otherwise I'll respin with this change
> tomorrow.
Sure, let me adjust this on merge. I'm still reviewing the rest.
--
Stefano
next prev parent reply other threads:[~2024-02-28 9:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 5:55 [PATCH 0/6] Allow more use of iovecs in pcap and tap interfaces David Gibson
2024-02-22 5:55 ` [PATCH 1/6] util: Add helper to find offset into io vector David Gibson
2024-02-27 14:23 ` Stefano Brivio
2024-02-27 23:27 ` David Gibson
2024-02-22 5:55 ` [PATCH 2/6] pcap: Update pcap_frame() to take an iovec and offset David Gibson
2024-02-27 14:23 ` Stefano Brivio
2024-02-22 5:55 ` [PATCH 3/6] util: Add write_remainder() helper David Gibson
2024-02-27 14:25 ` Stefano Brivio
2024-02-28 0:44 ` David Gibson
2024-02-28 6:24 ` Stefano Brivio
2024-02-28 9:04 ` David Gibson
2024-02-28 9:22 ` Stefano Brivio [this message]
2024-02-22 5:56 ` [PATCH 4/6] pcap: Handle short writes in pcap_frame() David Gibson
2024-02-22 5:56 ` [PATCH 5/6] pcap: Allow pcap_frame() and pcap_multiple() to take multi-buffer frames David Gibson
2024-02-27 14:26 ` Stefano Brivio
2024-02-22 5:56 ` [PATCH 6/6] tap: Use write_remainder() in tap_send_frames_passt() David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240228102247.63854842@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=lvivier@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).