From: Stefano Brivio <sbrivio@redhat.com>
To: Jon Maloy <jmaloy@redhat.com>
Cc: dgibson@redhat.com, david@gibson.dropbear.id.au, passt-dev@passt.top
Subject: Re: [PATCH v2] conf: use a single buffer for print formatting in conf_print()
Date: Wed, 15 Apr 2026 21:38:20 +0200 (CEST) [thread overview]
Message-ID: <20260415213819.28869768@elisabeth> (raw)
In-Reply-To: <20260327195551.271076-1-jmaloy@redhat.com>
On Fri, 27 Mar 2026 15:55:51 -0400
Jon Maloy <jmaloy@redhat.com> wrote:
> The function conf_print() uses three different buffers as target
> for address print formatting. This is unnecessary, as a single
> buffer of length INANY_ADDRSTRLEN has sufficient space for all
> address types, IPv4, IPv6 and MAC. There is no risk for conflicts,
> since all formatting is followed by an immediate info() printout.
>
> To make our life easier in the following commits, we do this
> simplification here.
>
> Signed-off-by: Jon Maloy <jmaloy@redhat.com>
>
> ---
> v2: - Changed buffer length to INANY_ADDSTRLEN
> - Eliminated use of same buffer in same info() printout.
Applied, sorry for the delay.
--
Stefano
prev parent reply other threads:[~2026-04-15 19:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 19:55 Jon Maloy
2026-04-15 19:38 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260415213819.28869768@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=dgibson@redhat.com \
--cc=jmaloy@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).