Re: [PATCH v3] tap, tcp, udp: Use rate-limited logging

[Stefano Brivio <sbrivio@redhat.com>]

On Mon, 13 Apr 2026 16:25:52 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:

> On Fri, Apr 10, 2026 at 04:07:37PM +0530, Anshu Kumari wrote:
> > Now that rate-limited logging macros are available, promote several
> > debug messages to higher severity levels.  These messages were
> > previously kept at debug to prevent guests from flooding host
> > logs, but with rate limiting they can safely be made visible in
> > normal operation.
> > 
> > In tap.c, refactor tap4_is_fragment() to use warn_ratelimit() instead
> > of its ad-hoc rate limiting, and promote the guest MAC address change
> > message to info level.
> > 
> > In tcp.c, promote the invalid TCP SYN endpoint message to warn level.
> > 
> > In udp.c, promote dropped datagram messages to warn level, and
> > rate-limit the unrecoverable socket error message.
> > 
> > In udp_flow.c, promote flow allocation failures to err_ratelimit.
> > 
> > Link: https://bugs.passt.top/show_bug.cgi?id=134
> > Signed-off-by: Anshu Kumari <anskuma@redhat.com>  
> 
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> 
> > ---
> >  v3:
> >    - Promote flow allocation failures to err_ratelimit from
> >      warn_ratelimit.  
> 
> Nit: doesn't affect the validity of the patch itself, but I'd consider
> "promotion" in this context as going from a less severe to more severe
> error level.  So going from 'err' to 'warn' is a demotion, not a
> promotion.

Wait but this is now going _from_ 'warn' _to_ 'err', so it's indeed a
promotion, isn't it?

-- 
Stefano