From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top, Laurent Vivier <lvivier@redhat.com>
Subject: Re: [PATCH v3 00/11] Rework forwarding option parsing
Date: Tue, 21 Apr 2026 00:33:27 +0200 (CEST) [thread overview]
Message-ID: <20260421003326.64a03015@elisabeth> (raw)
In-Reply-To: <20260417050520.102247-1-david@gibson.dropbear.id.au>
On Fri, 17 Apr 2026 15:05:09 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:
> This series makes a number of significant reworks to how we process
> forwarding options (-t, -u, -T and -U) in passt & pasta. This is
> largely motivated by moving towards being able to share this code with
> a configuration update tool. However, along the way it also enables
> some forwarding configurations that were technically possible with the
> forwarding table but couldn't be specified on the command line, in
> particular bug 180.
>
> There is still a bunch of work needed to make the parsing code truly
> shareable with pesto, but this is a solid start.
>
> v3:
> * Removed already merged patches
> * Further revisions based on Stefano's review, including
> * Improved example text in manpage and usage
> * More flexible rule dumping
> * Re-integrated conflict checking in fwd_rule_add()
Applied up to 6/11, with the nit in 3/11 reported by Laurent ("double
space between ) and {") fixed.
The rest looks good to me, minus pending comments (all from Laurent).
--
Stefano
next prev parent reply other threads:[~2026-04-20 22:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 5:05 David Gibson
2026-04-17 5:05 ` [PATCH v3 01/11] doc: Rework man page description of port specifiers David Gibson
2026-04-20 13:31 ` Laurent Vivier
2026-04-17 5:05 ` [PATCH v3 02/11] conf: Move "all" handling to port specifier David Gibson
2026-04-20 13:44 ` Laurent Vivier
2026-04-17 5:05 ` [PATCH v3 03/11] conf: Allow user-specified auto-scanned port forwarding ranges David Gibson
2026-04-20 14:45 ` Laurent Vivier
2026-04-17 5:05 ` [PATCH v3 04/11] conf: Move SO_BINDTODEVICE workaround to conf_ports() David Gibson
2026-04-20 15:06 ` Laurent Vivier
2026-04-17 5:05 ` [PATCH v3 05/11] conf: Don't pass raw commandline argument to conf_ports_spec() David Gibson
2026-04-20 16:11 ` Laurent Vivier
2026-04-17 5:05 ` [PATCH v3 06/11] fwd, conf: Add capabilities bits to each forwarding table David Gibson
2026-04-20 16:17 ` Laurent Vivier
2026-04-17 5:05 ` [PATCH v3 07/11] conf, fwd: Stricter rule checking in fwd_rule_add() David Gibson
2026-04-20 16:48 ` Laurent Vivier
2026-04-17 5:05 ` [PATCH v3 08/11] fwd_rule: Move ephemeral port probing to fwd_rule.c David Gibson
2026-04-20 16:52 ` Laurent Vivier
2026-04-17 5:05 ` [PATCH v3 09/11] fwd, conf: Move rule parsing code to fwd_rule.[ch] David Gibson
2026-04-20 17:06 ` Laurent Vivier
2026-04-17 5:05 ` [PATCH v3 10/11] fwd_rule: Move conflict checking back within fwd_rule_add() David Gibson
2026-04-20 17:15 ` Laurent Vivier
2026-04-17 5:05 ` [PATCH v3 11/11] fwd: Generalise fwd_rules_info() David Gibson
2026-04-20 17:21 ` Laurent Vivier
2026-04-20 22:33 ` Stefano Brivio [this message]
2026-04-21 0:05 ` [PATCH v3 00/11] Rework forwarding option parsing David Gibson
2026-04-21 0:10 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260421003326.64a03015@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=lvivier@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).