From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top, Jan Palus <jpalus@fastmail.com>
Subject: Re: [PATCH 0/3] Fix broken build with -DNDEBUG
Date: Sat, 16 May 2026 17:46:44 +0200 (CEST) [thread overview]
Message-ID: <20260516174643.6c0c5e24@elisabeth> (raw)
In-Reply-To: <20260515041312.317644-1-david@gibson.dropbear.id.au>
On Fri, 15 May 2026 14:13:09 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:
> Fix the trivial but nasty with -DNDEBUG builds recently reported by
> Jan Palus. While we're there, add a couple of extra build tests.
> These wouldn't actually catch this problem, but they're better than
> nothing and do catch the #include problem I also spotted.
>
> David Gibson (3):
> test: Extend exeter build tests to cover more recent binaries
> Fix build with -DNDEBUG
> test: Add test for builds with -DNDEBUG
Applied, with 2/3 amended as suggested by Jan.
Jan, I'll let you know once I tag a new release so that you can drop
your no-assert.patch.
I'm trying to figure out, first, a couple of potential regressions
(https://bugs.passt.top/show_bug.cgi?id=202,
https://bugs.passt.top/show_bug.cgi?id=203) so that those can be
fixed in the new release as well, but it might be a while before I even
get to look into them, and I won't wait more than a few days with a new
release in any case.
--
Stefano
next prev parent reply other threads:[~2026-05-16 15:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 4:13 David Gibson
2026-05-15 4:13 ` [PATCH 1/3] test: Extend exeter build tests to cover more recent binaries David Gibson
2026-05-15 4:13 ` [PATCH 2/3] Fix build with -DNDEBUG David Gibson
2026-05-15 11:05 ` Jan Palus
2026-05-16 6:28 ` David Gibson
2026-05-16 9:27 ` Stefano Brivio
2026-05-16 11:12 ` David Gibson
2026-05-15 4:13 ` [PATCH 3/3] test: Add test for builds " David Gibson
2026-05-16 15:46 ` Stefano Brivio [this message]
2026-05-17 1:08 ` [PATCH 0/3] Fix broken build " David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260516174643.6c0c5e24@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=jpalus@fastmail.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).