From: Laurent Vivier <lvivier@redhat.com>
To: passt-dev@passt.top
Cc: Laurent Vivier <lvivier@redhat.com>
Subject: [PATCH] inany: Fix doc comment to match u32 field, not u64
Date: Wed, 17 Jun 2026 14:21:03 +0200 [thread overview]
Message-ID: <20260617122103.97215-1-lvivier@redhat.com> (raw)
The original siphash incremental patch added a u64[2] member to
union inany_addr for hashing. During review, this was changed to u32[4]
to preserve 4-byte alignment: a u64 member would have forced 8-byte
alignment on the union, mismatching struct in6_addr.
The doc comment was not updated, fix @u64 references to @u32.
Fixes: fc8f0f8c48ef ("siphash: Use incremental rather than all-at-once siphash functions")
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
inany.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/inany.h b/inany.h
index 73385b916240..6bf3ecaa0e7d 100644
--- a/inany.h
+++ b/inany.h
@@ -22,9 +22,9 @@
* @v4mapped.zero: All zero-bits for an IPv4 address
* @v4mapped.one: All one-bits for an IPv4 address
* @v4mapped.a4: If @a6 is an IPv4 mapped address, the IPv4 address
- * @u64: As an array of u64s (solely for hashing)
+ * @u32: As an array of u32s (solely for hashing)
*
- * @v4mapped and @u64 shouldn't be accessed except via helpers.
+ * @v4mapped and @u32 shouldn't be accessed except via helpers.
*/
union inany_addr {
struct in6_addr a6;
--
2.54.0
reply other threads:[~2026-06-17 12:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260617122103.97215-1-lvivier@redhat.com \
--to=lvivier@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).