From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH v3 0/6] Improvements to flow specific logging
Date: Fri, 19 Jun 2026 21:43:52 +0200 (CEST) [thread overview]
Message-ID: <20260619214351.14f60ee9@elisabeth> (raw)
In-Reply-To: <20260619152626.3033033-1-david@gibson.dropbear.id.au>
On Sat, 20 Jun 2026 01:26:20 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:
> While working on podman bug 23739, I found some deficiences in how and
> when we report various socket errors related to specific flows. Here
> are some preliminary patches to improve that.
>
> v3:
> * Added a attribute((printf)) for the base flow log function
> * And fixed a couple of bad calls that caught
> * Removed one change from a plain log to a flow-specific log in UDP,
> where it turned out we didn't necessarily have a well defined flow
> * Fixing a cppcheck warning in the process
> * Put an explanatory comment and clang-tidy suppression for the (very
> limited) recursion in flow_log__()
Applied.
--
Stefano
prev parent reply other threads:[~2026-06-19 19:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-19 15:26 David Gibson
2026-06-19 15:26 ` [PATCH v3 1/6] flow: Regularise flow specific logging helpers David Gibson
2026-06-19 15:26 ` [PATCH v3 2/6] flow: Indent flow details messages David Gibson
2026-06-19 15:26 ` [PATCH v3 3/6] flow: Include flow details with higher priority log messages David Gibson
2026-06-19 15:26 ` [PATCH v3 4/6] flow, udp: Fix errno handling in udp_flow_sock() David Gibson
2026-06-19 15:26 ` [PATCH v3 5/6] flow, treewide: Promote priority of selected flow-linked messages David Gibson
2026-06-19 15:26 ` [PATCH v3 6/6] udp: Improve messages for errors getting errors David Gibson
2026-06-19 19:43 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260619214351.14f60ee9@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).