Re: [PATCH 02/12] conf: Use parameter instead of global in conf_nat()

[Stefano Brivio <sbrivio@redhat.com>]

On Fri, 26 Jun 2026 17:09:53 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:

> Conf nat takes a parameter @arg for the argument it's parsing.  However on

Nit: conf_nat().

> error we print instead optarg, the getopt() global.  This happens to be the
> same thing at the time of the call, but it's not the right way to get to
> it.
> 
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
>  conf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/conf.c b/conf.c
> index 4755a9f4..6ab8efec 100644
> --- a/conf.c
> +++ b/conf.c
> @@ -1049,7 +1049,7 @@ static void conf_nat(const char *arg, struct in_addr *addr4,
>  	    !IN4_IS_ADDR_MULTICAST(addr4))
>  		return;
>  
> -	die("Invalid address to remap to host: %s", optarg);
> +	die("Invalid address to remap to host: %s", arg);
>  }
>  
>  /**

-- 
Stefano