Re: [PATCH] pif: Add message to static_assert for C11 compliance, fix build with gcc 8

[Stefano Brivio <sbrivio@redhat.com>]

On Sun, 19 Jul 2026 14:05:27 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:

> On Sat, Jul 18, 2026 at 09:41:34AM +0200, Stefano Brivio wrote:
> > Seen with gcc 8.5:
> > 
> > ---
> > In file included from passt.h:18,
> >                  from qrap.c:36:
> > pif.h: In function 'pif_type':
> > pif.h:48:44: error: expected ',' before ')' token
> >   static_assert(sizeof("?") <= PIF_NAME_SIZE);
> >                                             ^
> > make: *** [Makefile:105: qrap] Error 1
> > ---
> > 
> > As noted in ba84a3b17af8 ("treewide: Add messages to static_assert()
> > calls"), static_assert() calls need a message to comply with C11. The
> > form without message is supported starting from C23 only.
> > 
> > Fixes: cbcd4284111f ("pif: Limit pif names to 128 bytes")
> > Signed-off-by: Stefano Brivio <sbrivio@redhat.com>  
> 
> Huh.  Weird I didn't get a warning for this one, I've caught this same
> mistake a bunch of times before because of a warning, though I forget
> if it came from the compiler or one of the static checkers.

Same here, I didn't get a warning either, but in ba84a3b17af8 you
mentioned clang-tidy reporting warnings only in some cases, so I guess
that's the kind of warning you would have expected.

-- 
Stefano