From: Stefano Brivio <sbrivio@redhat.com>
To: Jon Maloy <jmaloy@redhat.com>
Cc: david@gibson.dropbear.id.au, passt-dev@passt.top
Subject: Re: [PATCH v10] pasta: Refactor pasta_ns_conf() to reduce nesting
Date: Mon, 21 Sep 2026 21:57:39 +0200 (CEST) [thread overview]
Message-ID: <20260921215738.70905447@elisabeth> (raw)
In-Reply-To: <20260918174946.2366810-1-jmaloy@redhat.com>
On Fri, 18 Sep 2026 13:49:46 -0400
Jon Maloy <jmaloy@redhat.com> wrote:
> Extract address and route configuration into two new helper functions
> pasta_conf_addrs() and pasta_conf_routes(), and replace the outer
> if (c->pasta_conf_ns) block with an early return. This reduces
> indentation and eliminates the goto labels.
>
> No functional change.
>
> Signed-off-by: Jon Maloy <jmaloy@redhat.com>
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Uh-oh, wait a moment. The clang-tidy test reminded me that I already
reviewed this two months ago:
https://archives.passt.top/passt-dev/20260715091124.410d2ed6@elisabeth/
This v10 seems to be the same (minus rebase) as the v10 I
already commented on.
--
Stefano
next prev parent reply other threads:[~2026-09-21 19:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 17:49 Jon Maloy
2026-09-21 19:57 ` Stefano Brivio [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-07-13 17:26 Jon Maloy
2026-07-14 0:05 ` David Gibson
2026-07-15 7:11 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921215738.70905447@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=jmaloy@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).