From: Stefano Brivio <sbrivio@redhat.com>
To: Anshu Kumari <anskuma@redhat.com>
Cc: passt-dev@passt.top, lvivier@redhat.com
Subject: Re: [PATCH v7 2/7] dhcp: Add option configuration tracking with enum opt_conf
Date: Thu, 08 Oct 2026 00:06:11 +0200 (CEST) [thread overview]
Message-ID: <20261008000610.14af81c4@elisabeth> (raw)
In-Reply-To: <20261001131602.653553-3-anskuma@redhat.com>
On Thu, 1 Oct 2026 18:45:55 +0530
Anshu Kumari <anskuma@redhat.com> wrote:
> @@ -243,6 +256,7 @@ static void opt_set_dns_search(const struct ctx *c, size_t max_len)
> int i;
>
> opts[119].slen = 0;
> + opts[119].conf = OPT_DEFAULT;
I think that at this point, instead of doing this...
>
> for (i = 0; i < 255; i++)
> max_len -= opts[i].slen;
> @@ -291,7 +305,7 @@ static void opt_set_dns_search(const struct ctx *c, size_t max_len)
> }
>
> if (!opts[119].slen)
> - opts[119].slen = -1;
> + opts[119].conf = OPT_UNSET;
...it would make more sense to simply set opts[119].conf here, that is:
if (opts[119].slen)
opts[119].conf = OPT_DEFAULT;
--
Stefano
next prev parent reply other threads:[~2026-10-07 22:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 13:15 [PATCH v7 0/7] Add --dhcp-boot and --dhcp-opt options Anshu Kumari
2026-10-01 13:15 ` [PATCH v7 1/7] dhcp: Refactor fill_one() to operate on a generic buffer Anshu Kumari
2026-10-01 13:15 ` [PATCH v7 2/7] dhcp: Add option configuration tracking with enum opt_conf Anshu Kumari
2026-10-07 22:06 ` Stefano Brivio [this message]
2026-10-01 13:15 ` [PATCH v7 3/7] dhcp: Add --dhcp-opt with option table and value parser Anshu Kumari
2026-10-07 22:06 ` Stefano Brivio
2026-10-01 13:15 ` [PATCH v7 4/7] dhcp: Add --dhcp-boot command-line option Anshu Kumari
2026-10-07 22:06 ` Stefano Brivio
2026-10-01 13:15 ` [PATCH v7 5/7] dhcp: Change fill_one() to return void Anshu Kumari
2026-10-07 22:06 ` Stefano Brivio
2026-10-01 13:15 ` [PATCH v7 6/7] dhcp: Add option overload Anshu Kumari
2026-10-07 22:06 ` Stefano Brivio
2026-10-01 13:16 ` [PATCH v7 7/7] dhcp: Add RFC 3396 option splitting for concatenation-requiring options Anshu Kumari
2026-10-07 22:06 ` Stefano Brivio
2026-10-07 22:06 ` [PATCH v7 0/7] Add --dhcp-boot and --dhcp-opt options Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261008000610.14af81c4@elisabeth \
--to=sbrivio@redhat.com \
--cc=anskuma@redhat.com \
--cc=lvivier@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).