public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: Martin Schitter <ms+git@mur.at>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] netlink: Fix nl_route_dup by 3-step processing
Date: Wed, 11 Nov 2026 02:47:10 +0100 (CET)	[thread overview]
Message-ID: <20261111024709.223fabdc@elisabeth> (raw)
In-Reply-To: <20261107114621.804266-1-ms+git@mur.at>

On Sat,  7 Nov 2026 12:46:21 +0100
Martin Schitter <ms+git@mur.at> wrote:

> Eliminate the route entries capacity limitations of nl_route_dup
> by copying them to the destination namespace in three successive
> steps to bypass dependency issues. This approach is inspired by
> the code design used in the restore subcommand of iproute2.
>
> [...]

Sorry, I'm not sure why, but this breaks Podman tests on my setup,
which has (for IPv4) a single /27 address, and a default, single route
via the gateway.  If I do:

  ./pasta -a 192.0.2.1

I get EINVAL on the second route insertion in nl_route_dup().  If the
address is configured as /32 it works, if it's anything else (/31 or
shorter mask), it doesn't.

Isolated one-line reproducer (which should be independent from the
network setup):

  $ ./pasta -Ix -- sh -c 'ip l set dev x up && ip a a 198.50.100.2/31 dev x && ./pasta -4 --config-net -a 192.0.2.1'
  Couldn't set IPv4 route(s) in guest: Invalid argument

I didn't debug further than that.

-- 
Stefano


      reply	other threads:[~2026-11-11  1:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-07 11:46 Martin Schitter
2026-11-11  1:47 ` Stefano Brivio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261111024709.223fabdc@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=ms+git@mur.at \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).