From: Stefano Brivio <sbrivio@redhat.com>
To: Jon Maloy <jmaloy@redhat.com>
Cc: david@gibson.dropbear.id.au, passt-dev@passt.top
Subject: Re: [PATCH v16] passt, pasta: Introduce unified multi-address data structures
Date: Wed, 11 Nov 2026 08:03:41 +0100 (CET) [thread overview]
Message-ID: <20261111080340.61db3b60@elisabeth> (raw)
In-Reply-To: <20261105001112.2495089-1-jmaloy@redhat.com>
On Wed, 4 Nov 2026 19:11:12 -0500
Jon Maloy <jmaloy@redhat.com> wrote:
> As preparation for supporting multiple addresses per interface,
> we replace the single addr/prefix_len fields with an array. The
> array consists of a new struct inany_addr_entry containing an
> address and prefix length, both in inany_addr format.
>
> Despite some code refactoring, there are only two real functional
> changes:
> - The indicated IPv6 prefix length is now properly stored, instead
> of being ignored and overridden with the hardcoded value 64, as
> has been the case until now.
> - Since even IPv4 addresses now are stored in IPv6 format, we
> also store the corresponding prefix length in that format,
> i.e. using the range [96,128] instead of [0,32].
>
> In conf_ip6(), the explicit IN6_IS_ADDR_UNSPECIFIED() check on the
> address at the end of the function is no longer needed: for
> host-discovered addresses, it is now checked inside the if (!a) block
> before calling fwd_set_addr(); for user-provided addresses (via -a),
> validation already rejects unspecified addresses at parse time.
>
> Signed-off-by: Jon Maloy <jmaloy@redhat.com>
Applied, finally! Sorry for the delay.
--
Stefano
prev parent reply other threads:[~2026-11-11 7:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 0:11 Jon Maloy
2026-11-11 7:03 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261111080340.61db3b60@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=jmaloy@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).