* [PATCH] cppcheck: Fix scope of the variable 'type_or_state'
@ 2026-11-19 12:49 Laurent Vivier
0 siblings, 0 replies; only message in thread
From: Laurent Vivier @ 2026-11-19 12:49 UTC (permalink / raw)
To: passt-dev; +Cc: Laurent Vivier
Fix following cppcheck 2.22.0 error:
flow.c:289:14: style: The scope of the variable 'type_or_state' can be reduced. [variableScope]
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
flow.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/flow.c b/flow.c
index 27a24a4c253d..f9fbaefe761a 100644
--- a/flow.c
+++ b/flow.c
@@ -286,7 +286,6 @@ int flowside_connect(const struct ctx *c, int s,
void flow_log__(const struct flow_common *f, int pri, bool perror, bool details,
enum flow_state state, const char *fmt, ...)
{
- const char *type_or_state;
int errno_ = errno;
char msg[BUFSIZ];
va_list args;
@@ -299,6 +298,8 @@ void flow_log__(const struct flow_common *f, int pri, bool perror, bool details,
logmsg(!perror, false, pri, "Flow: not found, error: %s", msg);
details = false;
} else {
+ const char *type_or_state;
+
/* Show type if it's set, otherwise the state */
if (f->state < FLOW_STATE_TYPED)
type_or_state = FLOW_STATE(f);
--
2.56.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-11-19 12:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-19 12:49 [PATCH] cppcheck: Fix scope of the variable 'type_or_state' Laurent Vivier
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).