Re: [PATCH] conf: Don't warn if nameservers were found, but won't be advertised

[Paul Holzinger <pholzing@redhat.com>]

Thanks Stefano

On 08/03/2024 00:25, Stefano Brivio wrote:
> Starting from commit 3a2afde87dd1 ("conf, udp: Drop mostly duplicated
> dns_send arrays, rename related fields"), we won't add to c->ip4.dns
> and c->ip6.dns nameservers that can't be used by the guest or
> container, and we won't advertise them.
>
> However, the fact that we don't advertise any nameserver doesn't mean
> that we didn't find any, and we should warn only if we couldn't find
> any.
>
> This is particularly relevant in case both --dns-forward and
> --no-map-gw are passed, and a single loopback address is listed in
> /etc/resolv.conf: we'll forward queries directed to the address
> specified by --dns-forward to the loopback address we found, we
> won't advertise that address, so we shouldn't warn: this is a
> perfectly legitimate usage.
>
> Reported-by: Paul Holzinger <pholzing@redhat.com>
> Link: https://github.com/containers/podman/issues/19213
> Fixes: 3a2afde87dd1 ("conf, udp: Drop mostly duplicated dns_send arrays, rename related fields")
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Tested-by: Paul Holzinger <pholzing@redhat.com>