public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Laurent Vivier <lvivier@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH 4/4] tcp: Update TCP checksum using an iovec array
Date: Wed, 25 Sep 2024 09:27:03 +0200	[thread overview]
Message-ID: <61d4aaa5-8701-40ac-8810-08c2e28c43cf@redhat.com> (raw)
In-Reply-To: <ZvO1YG_Su82EHrMX@zatzit.fritz.box>

On 25/09/2024 09:01, David Gibson wrote:
>> I don't want to write complicated code only to write the checksum of
>> the tcp header.
> I agree, but I think we should at least test and bail with an error
> message if our assumptions about the alignments of the IOVs were given
> aren't true.

Do you think an ASSERT() is enough?

Thanks,
Laurent


  reply	other threads:[~2024-09-25  7:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-24 15:46 [PATCH 0/4] tcp: use csum_iov() in tcp_update_check_tcp[4|6]() Laurent Vivier
2024-09-24 15:46 ` [PATCH 1/4] tcp: Use tcp_payload_t rather than tcphdr Laurent Vivier
2024-09-24 15:46 ` [PATCH 2/4] pcap: Add an offset argument in pcap_iov() Laurent Vivier
2024-09-25  1:21   ` David Gibson
2024-09-24 15:46 ` [PATCH 3/4] checksum: Add an offset argument in csum_iov() Laurent Vivier
2024-09-25  0:51   ` David Gibson
2024-09-24 15:46 ` [PATCH 4/4] tcp: Update TCP checksum using an iovec array Laurent Vivier
2024-09-25  1:12   ` David Gibson
2024-09-25  6:40     ` Laurent Vivier
2024-09-25  7:01       ` David Gibson
2024-09-25  7:27         ` Laurent Vivier [this message]
2024-09-25  7:31           ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61d4aaa5-8701-40ac-8810-08c2e28c43cf@redhat.com \
    --to=lvivier@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).