public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Laine Stump <laine@redhat.com>
To: Libvirt <libvir-list@redhat.com>
Cc: sbrivio@redhat.com, passt-dev@passt.top, "Ján Tomko" <jtomko@redhat.com>
Subject: Re: [libvirt PATCH 7/9] qemu: add passtStateDir to qemu driver config
Date: Mon, 9 Jan 2023 09:02:18 -0500	[thread overview]
Message-ID: <72f623eb-01cf-85a3-de9f-48ffaf97f28a@redhat.com> (raw)
In-Reply-To: <Y7vBAVRaPuhWetj+@fedora>

On 1/9/23 2:23 AM, Ján Tomko wrote:
> On a Sunday in 2023, Laine Stump wrote:
>> -- 
>>
>> It seems a bit wasteful to allocate another string for this, since
>> it is 100% always ${stateDir}/passt, but everyone else is doing this
>> (e.g. slirpStateDir), so I'm just following along with the cult.
>>
> 
> Did you mean to mark this as a note under '---'?

Yes and no :-)

If it was me coming in later and seeing this new field I would wonder 
"why did they do that?" (just as I did with slirpStateDir, but that ship 
has sailed long ago), so I feel compelled to leave a note explaining 
myself. On the other hand, there's no *harm* to having it (other than 
the extra memory used), and commit logs referring to cults probably 
doesn't do much to inspire confidence, so I should probably leave it out 
when I push :-)

> 
>> Signed-off-by: Laine Stump <laine@redhat.com>
>> ---
>> src/qemu/qemu_conf.c   |  2 ++
>> src/qemu/qemu_conf.h   |  1 +
>> src/qemu/qemu_driver.c | 12 ++++++++++++
>> 3 files changed, 15 insertions(+)
> 
> Either way:
> Reviewed-by: Ján Tomko <jtomko@redhat.com>
> 
> Jano


  reply	other threads:[~2023-01-09 14:02 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-09  4:11 [libvirt PATCH 0/9] Support libvirt-managed QEMU domain <interface> backed by a passt process Laine Stump
2023-01-09  4:11 ` [libvirt PATCH 1/9] conf: rename virDomainNetBackend* to virDomainNetDriver* Laine Stump
2023-01-09  5:40   ` Ján Tomko
2023-01-09  4:11 ` [libvirt PATCH 2/9] conf: move anonymous backend struct from virDomainNetDef into its own struct Laine Stump
2023-01-09  5:41   ` Ján Tomko
2023-01-09  4:11 ` [libvirt PATCH 3/9] conf: put interface <backend> parsing/formatting separate functions Laine Stump
2023-01-09  5:47   ` Ján Tomko
2023-01-09  7:04     ` Laine Stump
2023-01-09  4:11 ` [libvirt PATCH 4/9] conf: add passt XML additions to schema Laine Stump
2023-01-09  5:48   ` Ján Tomko
2023-01-11 18:33   ` Daniel P. Berrangé
2023-01-12 14:45     ` Laine Stump
2023-01-12 17:28       ` Stefano Brivio
2023-01-12 18:12       ` Jiri Denemark
2023-01-09  4:11 ` [libvirt PATCH 5/9] conf: parse/format passt-related XML additions Laine Stump
2023-01-09  6:18   ` Ján Tomko
2023-01-09  4:11 ` [libvirt PATCH 6/9] qemu: new capability QEMU_CAPS_NETDEV_STREAM Laine Stump
2023-01-09  6:20   ` Ján Tomko
2023-01-09  4:11 ` [libvirt PATCH 7/9] qemu: add passtStateDir to qemu driver config Laine Stump
2023-01-09  6:23   ` Ján Tomko
2023-01-09 14:02     ` Laine Stump [this message]
2023-01-09  4:11 ` [libvirt PATCH 8/9] qemu: hook up passt config to qemu domains Laine Stump
2023-01-09  6:31   ` Ján Tomko
2023-01-09 14:14     ` Laine Stump
2023-01-09 14:51       ` Ján Tomko
2023-01-09 16:05         ` Laine Stump
2023-01-09  4:11 ` [libvirt PATCH 9/9] specfile: require passt for the build if fedora >= 36 or rhel >= 9 Laine Stump
2023-01-09  6:32   ` Ján Tomko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72f623eb-01cf-85a3-de9f-48ffaf97f28a@redhat.com \
    --to=laine@redhat.com \
    --cc=jtomko@redhat.com \
    --cc=libvir-list@redhat.com \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).