Re: [libvirt PATCH 7/9] qemu: add passtStateDir to qemu driver config

[Laine Stump <laine@redhat.com>]

On 1/9/23 2:23 AM, Ján Tomko wrote:
> On a Sunday in 2023, Laine Stump wrote:
>> -- 
>>
>> It seems a bit wasteful to allocate another string for this, since
>> it is 100% always ${stateDir}/passt, but everyone else is doing this
>> (e.g. slirpStateDir), so I'm just following along with the cult.
>>
> 
> Did you mean to mark this as a note under '---'?

Yes and no :-)

If it was me coming in later and seeing this new field I would wonder 
"why did they do that?" (just as I did with slirpStateDir, but that ship 
has sailed long ago), so I feel compelled to leave a note explaining 
myself. On the other hand, there's no *harm* to having it (other than 
the extra memory used), and commit logs referring to cults probably 
doesn't do much to inspire confidence, so I should probably leave it out 
when I push :-)

> 
>> Signed-off-by: Laine Stump <laine@redhat.com>
>> ---
>> src/qemu/qemu_conf.c   |  2 ++
>> src/qemu/qemu_conf.h   |  1 +
>> src/qemu/qemu_driver.c | 12 ++++++++++++
>> 3 files changed, 15 insertions(+)
> 
> Either way:
> Reviewed-by: Ján Tomko <jtomko@redhat.com>
> 
> Jano