From: Jiri Denemark <jdenemar@redhat.com>
To: Laine Stump <laine@redhat.com>
Cc: Libvirt <libvir-list@redhat.com>,
sbrivio@redhat.com, passt-dev@passt.top
Subject: Re: [libvirt PATCH 4/9] conf: add passt XML additions to schema
Date: Thu, 12 Jan 2023 19:12:29 +0100 [thread overview]
Message-ID: <Y8BNjXn7fhssyUG1@orkuz.int.mamuti.net> (raw)
In-Reply-To: <11955eac-2c40-7c21-2f15-91c4bdade4ed@redhat.com>
On Thu, Jan 12, 2023 at 09:45:39 -0500, Laine Stump wrote:
> On 1/11/23 1:33 PM, Daniel P. Berrangé wrote:
> > On Sun, Jan 08, 2023 at 11:11:07PM -0500, Laine Stump wrote:
> >> + <backend type='passt' logFile='/var/log/loglaw.blog' upstream='eth42'/>
> >
> > I don't think that 'upstream' is really describing a property of the
> > backend.
> >
> > This is expressing a traffic routing restriction for the 'user'
> > networking type. IMHO it should probably be using the existing
> > <source dev="xxxx"/> element, that is currently used by the
> > 'direct' networking type.
>
> I'm still not sure *exactly* what it does; it apparently grabs the
> routes that are fed to the guest from the given host interface; I should
> probably ask Stefano to explain it to me again (he described it once,
> but that was along with explanations of several other things).
>
> So it's not *exactly* the same as <source dev='xxx'/> for type='direct'
> (which determines the link-level connection rather than IP routing), but
> definitely very similar.
>
>
> > Can we see about fixing this before release.
>
> Yes, that makes sense. I'm not sure why I didn't think of it (usually I
> try *too* hard to re-use existing XML).
>
> I'll make a patch and send it later today.
Great, I'm waiting with tagging rc2 until this is done.
Jirka
next prev parent reply other threads:[~2023-01-12 18:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 4:11 [libvirt PATCH 0/9] Support libvirt-managed QEMU domain <interface> backed by a passt process Laine Stump
2023-01-09 4:11 ` [libvirt PATCH 1/9] conf: rename virDomainNetBackend* to virDomainNetDriver* Laine Stump
2023-01-09 5:40 ` Ján Tomko
2023-01-09 4:11 ` [libvirt PATCH 2/9] conf: move anonymous backend struct from virDomainNetDef into its own struct Laine Stump
2023-01-09 5:41 ` Ján Tomko
2023-01-09 4:11 ` [libvirt PATCH 3/9] conf: put interface <backend> parsing/formatting separate functions Laine Stump
2023-01-09 5:47 ` Ján Tomko
2023-01-09 7:04 ` Laine Stump
2023-01-09 4:11 ` [libvirt PATCH 4/9] conf: add passt XML additions to schema Laine Stump
2023-01-09 5:48 ` Ján Tomko
2023-01-11 18:33 ` Daniel P. Berrangé
2023-01-12 14:45 ` Laine Stump
2023-01-12 17:28 ` Stefano Brivio
2023-01-12 18:12 ` Jiri Denemark [this message]
2023-01-09 4:11 ` [libvirt PATCH 5/9] conf: parse/format passt-related XML additions Laine Stump
2023-01-09 6:18 ` Ján Tomko
2023-01-09 4:11 ` [libvirt PATCH 6/9] qemu: new capability QEMU_CAPS_NETDEV_STREAM Laine Stump
2023-01-09 6:20 ` Ján Tomko
2023-01-09 4:11 ` [libvirt PATCH 7/9] qemu: add passtStateDir to qemu driver config Laine Stump
2023-01-09 6:23 ` Ján Tomko
2023-01-09 14:02 ` Laine Stump
2023-01-09 4:11 ` [libvirt PATCH 8/9] qemu: hook up passt config to qemu domains Laine Stump
2023-01-09 6:31 ` Ján Tomko
2023-01-09 14:14 ` Laine Stump
2023-01-09 14:51 ` Ján Tomko
2023-01-09 16:05 ` Laine Stump
2023-01-09 4:11 ` [libvirt PATCH 9/9] specfile: require passt for the build if fedora >= 36 or rhel >= 9 Laine Stump
2023-01-09 6:32 ` Ján Tomko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8BNjXn7fhssyUG1@orkuz.int.mamuti.net \
--to=jdenemar@redhat.com \
--cc=laine@redhat.com \
--cc=libvir-list@redhat.com \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).