public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] passt.1: Fix description of --mtu option
Date: Sat, 18 Mar 2023 13:03:36 +1100	[thread overview]
Message-ID: <ZBUb+NqRCr0AbuHe@yekko> (raw)
In-Reply-To: <20230315091350.3767103-1-sbrivio@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1284 bytes --]

On Wed, Mar 15, 2023 at 10:13:50AM +0100, Stefano Brivio wrote:
> By default, 65520 bytes are advertised, and zero disables DHCP and
> NDP options.
> 
> Fixes: ec2b58ea4dc4 ("conf, dhcp, ndp: Fix message about default MTU, make NDP consistent")
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  passt.1 | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/passt.1 b/passt.1
> index 6136fa5..4c90634 100644
> --- a/passt.1
> +++ b/passt.1
> @@ -135,8 +135,10 @@ background (if configured to do so).
>  
>  .TP
>  .BR \-m ", " \-\-mtu " " \fImtu
> -Assign \fImtu\fR via DHCP (option 26) and NDP (option type 5).
> -By default, no MTU options will be sent.
> +Assign \fImtu\fR via DHCP (option 26) and NDP (option type 5). A zero value
> +disables assignment.
> +By default, the advertised MTU is 65520 bytes, that is, the maximum 802.3 MTU
> +minus the length of a 802.3 header, rounded to 32 bits (IPv4 words).
>  
>  .TP
>  .BR \-a ", " \-\-address " " \fIaddr

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2023-03-18  5:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-15  9:13 [PATCH] passt.1: Fix description of --mtu option Stefano Brivio
2023-03-18  2:03 ` David Gibson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZBUb+NqRCr0AbuHe@yekko \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).