public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
* [PATCH] passt.1: Fix description of --mtu option
@ 2023-03-15  9:13 Stefano Brivio
  2023-03-18  2:03 ` David Gibson
  0 siblings, 1 reply; 2+ messages in thread
From: Stefano Brivio @ 2023-03-15  9:13 UTC (permalink / raw)
  To: passt-dev

By default, 65520 bytes are advertised, and zero disables DHCP and
NDP options.

Fixes: ec2b58ea4dc4 ("conf, dhcp, ndp: Fix message about default MTU, make NDP consistent")
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
 passt.1 | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/passt.1 b/passt.1
index 6136fa5..4c90634 100644
--- a/passt.1
+++ b/passt.1
@@ -135,8 +135,10 @@ background (if configured to do so).
 
 .TP
 .BR \-m ", " \-\-mtu " " \fImtu
-Assign \fImtu\fR via DHCP (option 26) and NDP (option type 5).
-By default, no MTU options will be sent.
+Assign \fImtu\fR via DHCP (option 26) and NDP (option type 5). A zero value
+disables assignment.
+By default, the advertised MTU is 65520 bytes, that is, the maximum 802.3 MTU
+minus the length of a 802.3 header, rounded to 32 bits (IPv4 words).
 
 .TP
 .BR \-a ", " \-\-address " " \fIaddr
-- 
@@ -135,8 +135,10 @@ background (if configured to do so).
 
 .TP
 .BR \-m ", " \-\-mtu " " \fImtu
-Assign \fImtu\fR via DHCP (option 26) and NDP (option type 5).
-By default, no MTU options will be sent.
+Assign \fImtu\fR via DHCP (option 26) and NDP (option type 5). A zero value
+disables assignment.
+By default, the advertised MTU is 65520 bytes, that is, the maximum 802.3 MTU
+minus the length of a 802.3 header, rounded to 32 bits (IPv4 words).
 
 .TP
 .BR \-a ", " \-\-address " " \fIaddr
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] passt.1: Fix description of --mtu option
  2023-03-15  9:13 [PATCH] passt.1: Fix description of --mtu option Stefano Brivio
@ 2023-03-18  2:03 ` David Gibson
  0 siblings, 0 replies; 2+ messages in thread
From: David Gibson @ 2023-03-18  2:03 UTC (permalink / raw)
  To: Stefano Brivio; +Cc: passt-dev

[-- Attachment #1: Type: text/plain, Size: 1284 bytes --]

On Wed, Mar 15, 2023 at 10:13:50AM +0100, Stefano Brivio wrote:
> By default, 65520 bytes are advertised, and zero disables DHCP and
> NDP options.
> 
> Fixes: ec2b58ea4dc4 ("conf, dhcp, ndp: Fix message about default MTU, make NDP consistent")
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  passt.1 | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/passt.1 b/passt.1
> index 6136fa5..4c90634 100644
> --- a/passt.1
> +++ b/passt.1
> @@ -135,8 +135,10 @@ background (if configured to do so).
>  
>  .TP
>  .BR \-m ", " \-\-mtu " " \fImtu
> -Assign \fImtu\fR via DHCP (option 26) and NDP (option type 5).
> -By default, no MTU options will be sent.
> +Assign \fImtu\fR via DHCP (option 26) and NDP (option type 5). A zero value
> +disables assignment.
> +By default, the advertised MTU is 65520 bytes, that is, the maximum 802.3 MTU
> +minus the length of a 802.3 header, rounded to 32 bits (IPv4 words).
>  
>  .TP
>  .BR \-a ", " \-\-address " " \fIaddr

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-03-18  5:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-15  9:13 [PATCH] passt.1: Fix description of --mtu option Stefano Brivio
2023-03-18  2:03 ` David Gibson

Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).