Re: [PATCH] conf: We're interested in the MAC address, not in the MAC itself

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1260 bytes --]

On Fri, Apr 12, 2024 at 12:18:00AM +0200, Stefano Brivio wrote:
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  conf.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/conf.c b/conf.c
> index 9e0318a..90d3436 100644
> --- a/conf.c
> +++ b/conf.c
> @@ -625,7 +625,7 @@ static unsigned int conf_ip4(unsigned int ifi,
>  		int rc = nl_link_get_mac(nl_sock, ifi, mac);
>  		if (rc < 0) {
>  			char ifname[IFNAMSIZ];
> -			err("Couldn't discover MAC for %s: %s",
> +			err("Couldn't discover MAC address for %s: %s",
>  			    if_indextoname(ifi, ifname), strerror(-rc));
>  			return 0;
>  		}
> @@ -684,7 +684,7 @@ static unsigned int conf_ip6(unsigned int ifi,
>  		rc = nl_link_get_mac(nl_sock, ifi, mac);
>  		if (rc < 0) {
>  			char ifname[IFNAMSIZ];
> -			err("Couldn't discover MAC for %s: %s",
> +			err("Couldn't discover MAC address for %s: %s",
>  			    if_indextoname(ifi, ifname), strerror(-rc));
>  			return 0;
>  		}

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]