public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top, Laurent Vivier <lvivier@redhat.com>
Subject: Re: [PATCH v2 1/3] conf, fwd: Make ephemeral port logic more flexible
Date: Thu, 29 Aug 2024 16:53:40 +1000	[thread overview]
Message-ID: <ZtAa9HNE8sJ3I15W@zatzit.fritz.box> (raw)
In-Reply-To: <20240829065905.35be74c8@elisabeth>

[-- Attachment #1: Type: text/plain, Size: 703 bytes --]

On Thu, Aug 29, 2024 at 06:59:05AM +0200, Stefano Brivio wrote:
> Nit:
> 
> On Thu, 29 Aug 2024 11:32:40 +1000
> David Gibson <david@gibson.dropbear.id.au> wrote:
> 
> > +/* Empheral port range: values from RFC 6335 */
> > +static const uint16_t fwd_ephemeral_min = (1 << 15) + (1 << 14);
> > +static const uint16_t fwd_ephemeral_max = NUM_PORTS - 1;
> 
> Maybe you could use in_port_t instead, just for consistency with
> (almost) everything else, no advantages otherwise.

Duh, of course.

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2024-08-29  6:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-29  1:32 [PATCH v2 0/3] Probe host's ephemeral ports, rather than using RFC values David Gibson
2024-08-29  1:32 ` [PATCH v2 1/3] conf, fwd: Make ephemeral port logic more flexible David Gibson
2024-08-29  4:59   ` Stefano Brivio
2024-08-29  6:53     ` David Gibson [this message]
2024-08-29  1:32 ` [PATCH v2 2/3] conf, fwd: Don't attempt to forward port 0 David Gibson
2024-08-29  1:32 ` [PATCH v2 3/3] fwd, conf: Probe host's ephemeral ports David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZtAa9HNE8sJ3I15W@zatzit.fritz.box \
    --to=david@gibson.dropbear.id.au \
    --cc=lvivier@redhat.com \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).