From: Laine Stump <laine@redhat.com>
To: passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>,
Yalan Zhang <yalzhang@redhat.com>,
Stefano Brivio <sbrivio@redhat.com>
Subject: Re: [PATCH v2] passt.1: Fix typo, improve wording in examples of port forwarding specifiers
Date: Thu, 16 Feb 2023 12:48:17 -0500 [thread overview]
Message-ID: <a1bdedcb-514e-cce5-d0c1-bc1990c7e952@redhat.com> (raw)
In-Reply-To: <20230216183250.2442b366@elisabeth>
On 2/16/23 12:32 PM, Stefano Brivio wrote:
> On Thu, 16 Feb 2023 11:53:07 -0500
> Laine Stump <laine@redhat.com> wrote:
>
>> On 2/16/23 2:23 AM, Stefano Brivio wrote:
>>> Based on a patch from Laine, and reports from Laine and Yalan: fix
>>> the "22-80:32-90" example, and improve wording for the other ones:
>>> instead of using "to" to denote the end of a range, use "between ...
>>> and", so that it's clear we're *not* referring to target ports.
>>>
>>> Reported-by: Laine Stump <laine@redhat.com>
>>> Reported-by: Yalan Zhang <yalzhang@redhat.com>
>>> Fixes: da20f57f19dc ("passt, qrap: Add man pages")
>>> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
>>
>> Reviewed-by: Laine Stump <laine@redhat.com>
>>
>> (if I'm allowed :-)
>
> Oops, not anymore, I'm in the middle of pushing things out and running
> tests, I just pushed this, and I want to avoid rebasing the tree.
>
Oh, I wasn't talking about whether or not I "get documented credit for
spending a few minutes looking at someone else's work". Just saying the
equivalent of "Another set of eyes has looked at it and it seemed good",
although I guess using the official rb header to do that may imply
otherwise; that's just a force of habit :-)
prev parent reply other threads:[~2023-02-16 17:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 7:23 [PATCH v2] passt.1: Fix typo, improve wording in examples of port forwarding specifiers Stefano Brivio
2023-02-16 16:53 ` Laine Stump
2023-02-16 17:32 ` Stefano Brivio
2023-02-16 17:48 ` Laine Stump [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1bdedcb-514e-cce5-d0c1-bc1990c7e952@redhat.com \
--to=laine@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
--cc=yalzhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).