From: David Gibson <david@gibson.dropbear.id.au>
To: Jon Maloy <jmaloy@redhat.com>
Cc: sbrivio@redhat.com, passt-dev@passt.top
Subject: Re: [PATCH] test/lib: Pre-create context log files before starting tail
Date: Sun, 21 Jun 2026 11:15:43 +1000 [thread overview]
Message-ID: <ajc7P-sML6Xfkr1i@gractus.seuss> (raw)
In-Reply-To: <20260620200728.1720190-1-jmaloy@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1138 bytes --]
On Sat, Jun 20, 2026 at 04:07:28PM -0400, Jon Maloy wrote:
> pane_watch_contexts() starts tail -f --retry on context log files,
> but those files may not exist yet when tail starts, resulting in
> error messages in the tmux pane. Pre-create them with touch so
> tail can open them immediately.
Eh, sure. But if you do this, you shouldn't need the --retry any
more.
>
> Signed-off-by: Jon Maloy <jmaloy@redhat.com>
> ---
> test/lib/term | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/test/lib/term b/test/lib/term
> index 2d2d2182..23639e34 100755
> --- a/test/lib/term
> +++ b/test/lib/term
> @@ -252,6 +252,7 @@ pane_watch_contexts() {
> tmux select-pane -t ${__pane_number} -T "${__desc}"
> __cmd="tail -f --retry"
> for c; do
> + touch "${LOGDIR}/context_${c}.log"
> __cmd="${__cmd} ${LOGDIR}/context_${c}.log"
> done
> cmd_write ${__pane_number} "${__cmd}"
> --
> 2.52.0
>
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2026-06-21 1:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-20 20:07 Jon Maloy
2026-06-21 1:15 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajc7P-sML6Xfkr1i@gractus.seuss \
--to=david@gibson.dropbear.id.au \
--cc=jmaloy@redhat.com \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).