public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
* [PATCH] test/lib: Pre-create context log files before starting tail
@ 2026-06-20 20:07 Jon Maloy
  2026-06-21  1:15 ` David Gibson
  0 siblings, 1 reply; 2+ messages in thread
From: Jon Maloy @ 2026-06-20 20:07 UTC (permalink / raw)
  To: sbrivio, david, jmaloy, passt-dev

pane_watch_contexts() starts tail -f --retry on context log files,
but those files may not exist yet when tail starts, resulting in
error messages in the tmux pane.  Pre-create them with touch so
tail can open them immediately.

Signed-off-by: Jon Maloy <jmaloy@redhat.com>
---
 test/lib/term | 1 +
 1 file changed, 1 insertion(+)

diff --git a/test/lib/term b/test/lib/term
index 2d2d2182..23639e34 100755
--- a/test/lib/term
+++ b/test/lib/term
@@ -252,6 +252,7 @@ pane_watch_contexts() {
 	tmux select-pane -t ${__pane_number} -T "${__desc}"
 	__cmd="tail -f --retry"
 	for c; do
+		touch "${LOGDIR}/context_${c}.log"
 		__cmd="${__cmd} ${LOGDIR}/context_${c}.log"
 	done
 	cmd_write ${__pane_number} "${__cmd}"
-- 
2.52.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] test/lib: Pre-create context log files before starting tail
  2026-06-20 20:07 [PATCH] test/lib: Pre-create context log files before starting tail Jon Maloy
@ 2026-06-21  1:15 ` David Gibson
  0 siblings, 0 replies; 2+ messages in thread
From: David Gibson @ 2026-06-21  1:15 UTC (permalink / raw)
  To: Jon Maloy; +Cc: sbrivio, passt-dev

[-- Attachment #1: Type: text/plain, Size: 1138 bytes --]

On Sat, Jun 20, 2026 at 04:07:28PM -0400, Jon Maloy wrote:
> pane_watch_contexts() starts tail -f --retry on context log files,
> but those files may not exist yet when tail starts, resulting in
> error messages in the tmux pane.  Pre-create them with touch so
> tail can open them immediately.

Eh, sure.  But if you do this, you shouldn't need the --retry any
more.

> 
> Signed-off-by: Jon Maloy <jmaloy@redhat.com>
> ---
>  test/lib/term | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/test/lib/term b/test/lib/term
> index 2d2d2182..23639e34 100755
> --- a/test/lib/term
> +++ b/test/lib/term
> @@ -252,6 +252,7 @@ pane_watch_contexts() {
>  	tmux select-pane -t ${__pane_number} -T "${__desc}"
>  	__cmd="tail -f --retry"
>  	for c; do
> +		touch "${LOGDIR}/context_${c}.log"
>  		__cmd="${__cmd} ${LOGDIR}/context_${c}.log"
>  	done
>  	cmd_write ${__pane_number} "${__cmd}"
> -- 
> 2.52.0
> 

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-06-21  1:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-20 20:07 [PATCH] test/lib: Pre-create context log files before starting tail Jon Maloy
2026-06-21  1:15 ` David Gibson

Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).