Re: [PATCH v6 09/12] icmp: Pass queue pair explicitly through ICMP send path

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1133 bytes --]

On Fri, Jul 31, 2026 at 06:16:14PM +0200, Laurent Vivier wrote:
> icmp_sock_handler() uses QPAIR_DEFAULT when calling tap_icmp4_send()
> and tap_icmp6_send().  Thread a qpair parameter from the caller in
> passt_worker() so the queue pair is selected at the entry point rather
> than hard-coded inside the handler.
> 
> passt_worker() currently passes QPAIR_DEFAULT, preserving existing
> single-queue behavior.  This is a preparatory step for per-queue
> worker threads in vhost-user mode.
> 
> No functional change.
> 
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> @@ -67,9 +67,10 @@ static struct icmp_ping_flow *ping_at_sidx(flow_sidx_t sidx)
>   * @c:		Execution context
>   * @ref:	epoll reference
>   * @now:	Current timestamp
> + * @qpair:	Queue pair to process

As with TCP and UDP, some more precision in this description would
help.

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]