Re: [RFC v3 1/8] tap: Move the tap_hdr file to a separate file

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1934 bytes --]

On Sun, Aug 02, 2026 at 01:21:48PM +0000, Ammar Yasser wrote:
> It was defined in tap.h, put it on its own so that future callers won't
> need to depend on all definitions in tap.h
> 
> Signed-off-by: Ammar Yasser <aerosound161@gmail.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  tap.h     |  9 +--------
>  tap_hdr.h | 19 +++++++++++++++++++
>  2 files changed, 20 insertions(+), 8 deletions(-)
>  create mode 100644 tap_hdr.h
> 
> diff --git a/tap.h b/tap.h
> index b335933..1625975 100644
> --- a/tap.h
> +++ b/tap.h
> @@ -10,6 +10,7 @@
>  #include <stdint.h>
>  
>  #include "passt.h"
> +#include "tap_hdr.h"
>  
>  /** L2_MAX_LEN_PASTA - Maximum frame length for pasta mode (with L2 header)
>   *
> @@ -38,14 +39,6 @@
>  
>  struct udphdr;
>  
> -/**
> - * struct tap_hdr - tap backend specific headers
> - * @vnet_len:	Frame length (for qemu socket transport)
> - */
> -struct tap_hdr {
> -	uint32_t vnet_len;
> -} __attribute__((packed));
> -
>  /**
>   * tap_hdr_iov() - struct iovec for a tap header
>   * @c:		Execution context
> diff --git a/tap_hdr.h b/tap_hdr.h
> new file mode 100644
> index 0000000..15bdb5b
> --- /dev/null
> +++ b/tap_hdr.h
> @@ -0,0 +1,19 @@
> +/* SPDX-License-Identifier: GPL-2.0-or-later
> + * Copyright (c) 2021 Red Hat GmbH
> + * Author: Stefano Brivio <sbrivio@redhat.com>
> + */
> +
> +#ifndef TAP_HDR_H
> +#define TAP_HDR_H
> +
> +#include <stdint.h>
> +
> +/**
> + * struct tap_hdr - tap backend specific headers
> + * @vnet_len:	Frame length (for qemu socket transport)
> + */
> +struct tap_hdr {
> +	uint32_t vnet_len;
> +} __attribute__((packed));
> +
> +#endif /* TAP_HDR_H */
> -- 
> 2.34.1
> 

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]