public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top, Frajo Haider <frajo@frajo.fi>,
	Sean McGinnis <sean.mcginnis@gmail.com>
Subject: Re: [PATCH] fwd_rule: Restore forwarding of ephemeral ports for -t auto, -u auto
Date: Mon, 16 Nov 2026 14:10:22 +1100	[thread overview]
Message-ID: <avp0BlrgMiTdbdWb@gractus.seuss> (raw)
In-Reply-To: <20261115224044.1405061-1-sbrivio@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 2440 bytes --]

On Sun, Nov 15, 2026 at 11:40:44PM +0100, Stefano Brivio wrote:
> From: Frajo Haider <frajo@frajo.fi>
> 
> >From an original patch by Frajo: commit 4e09ddf03443 ("conf: Allow
> user-specified auto-scanned port forwarding ranges") made automatic
> port forwarding exclude ephemeral ports, consistently with -t all and
> -u all, and I thought this should actually be desirable, because those
> ports are ephemeral, after all, and no services should be bound to
> them.
> 
> On the other hand, services that can already be contacted on some
> other port might want to expose additional (ephemeral indeed) ports.
> So perhaps we should really expose them.
> 
> Now, Sean reports that this "feature" actually breaks things for the
> kind (Kubernetes-in-Docker) project, because Docker relies on the
> rootlesskit integration of pasta, which uses automatic port forwarding
> instead of explicit configuration.
> 
> So, feature or not (and I'm fairly convinced it's a bug by now), it
> causes a regression, so restore the previous behaviour: if ports are
> automatically forwarded, don't exclude ephemeral ports.
> 
> Reported-by: Frajo Haider <frajo@frajo.fi>
> Reported-by: Sean McGinnis <sean.mcginnis@gmail.com>
> Link: https://bugs.passt.top/show_bug.cgi?id=219
> Link: https://github.com/kubernetes-sigs/kind/issues/4293
> Fixes: 4e09ddf03443 ("conf: Allow user-specified auto-scanned port forwarding ranges")
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Note that until this patch is applied, the old behaviour can also be
forced with:
	-t 1024-65535,auto -u 1024-65535,auto

> ---
>  fwd_rule.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/fwd_rule.c b/fwd_rule.c
> index 312bc60..a1294d6 100644
> --- a/fwd_rule.c
> +++ b/fwd_rule.c
> @@ -694,7 +694,8 @@ static void fwd_rule_parse_ports(struct fwd_table *fwd, bool del, uint8_t proto,
>  
>  	/* Finally handle "all" and exclude only cases */
>  	if (exclude_only) {
> -		fwd_port_map_ephemeral(exclude);
> +		if (!(flags & FWD_SCAN))
> +			fwd_port_map_ephemeral(exclude);
>  
>  		fwd_rule_range_except(fwd, del, proto, addr, ifname,
>  				      1, NUM_PORTS - 1, exclude,
> -- 
> 2.43.0
> 

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2026-11-16  4:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 22:40 Stefano Brivio
2026-11-16  3:10 ` David Gibson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avp0BlrgMiTdbdWb@gractus.seuss \
    --to=david@gibson.dropbear.id.au \
    --cc=frajo@frajo.fi \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    --cc=sean.mcginnis@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).