public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: Lynxes Exe <lynxes.exe@gmail.com>, passt-dev@passt.top
Subject: Re: tcp: peer stuck in low_rtt_dst table loses window clamping, every new connection stalls on RTOs
Date: Wed, 18 Nov 2026 12:16:05 +1100	[thread overview]
Message-ID: <avz8R6lrK91ZS4qJ@gractus.seuss> (raw)
In-Reply-To: <20261117120427.776ab215@elisabeth>

[-- Attachment #1: Type: text/plain, Size: 2644 bytes --]

On Tue, Nov 17, 2026 at 12:04:28PM +0100, Stefano Brivio wrote:
> On Thu, 12 Nov 2026 17:09:20 +0100
> Lynxes Exe <lynxes.exe@gmail.com> wrote:
> 
> > Hi Stefano,
> > 
> > I apologize for the long wait. The issue took a while to represent itself.
> 
> No worries, it wasn't that long, thanks for following up.
> 
> > [...]
> >
> > 3. Patches
> > 
> > Attached, against current master (7380393):
> > 
> >   0001 tcp: Don't add peers to low RTT table before RTT is measured
> >   0002 tcp: Log additions to low RTT table
> > 
> > 0001 is your condition as you wrote it. 0002 logs only additions, with
> > flow_dbg(): the skip itself happens on every tcp_prepare_flags() call
> > until the first sample, which was 28 times for one connection in the
> > test above, so logging it would be noisy. Each patch builds without
> > warnings; I haven't run the test suite.
> 
> Thanks for the patches, and welcome to the git log!
> 
> I was about to merge both, but there's an issue with the first one, so
> I could just merge 2/2 for the moment.  I'm fairly confident that 1/2
> is actually correct, but it makes the migrate/rampstream_out test fail.
> 
> The migration functionality gives a hypervisor (currently this is only
> supported with QEMU) a way to "move" all our context, including TCP
> connections (!), between a source guest and a target guest, so that
> virtual machines can be moved to another host as they are, with a short
> interruption.  The stages_v2[] array in migrate.c gives an overview of
> what data can move to another instance of passt, and how.
> 
> That test checks that an outbound stream sent by a guest remains
> consistent as it's moved from a source instance to a target instance of
> passt.  With 1/2, the flow appears to stop mid way, or to not restart
> on the destination.
> 
> We don't copy the "low RTT" table during migration.  I didn't think it
> was needed, because, I thought, eventually the destination instance of
> passt should figure things out.  But it looks like it doesn't, and that
> bug with the initial ~0U value hid the issue until now, that is,
> (some?) migrated connections are _probably_ inserted by default in the
> table.  This is just a wild guess for the moment.

Seems like there's a real bug here, but just migrating the low RTT
table doesn't seem correct either: whether things are "local" or not
could change because of the migration.

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2026-11-18 13:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-28 13:15 Lynxes Exe
2026-10-29  1:11 ` David Gibson
2026-11-04 13:53 ` Stefano Brivio
2026-11-12 16:09   ` Lynxes Exe
2026-11-17 11:04     ` Stefano Brivio
2026-11-18  1:16       ` David Gibson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avz8R6lrK91ZS4qJ@gractus.seuss \
    --to=david@gibson.dropbear.id.au \
    --cc=lynxes.exe@gmail.com \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).