Re: [PATCH v6 07/18] fwd_rule: Fix some format specifiers

[Laurent Vivier <lvivier@redhat.com>]

On 5/3/26 23:55, Stefano Brivio wrote:
> From: David Gibson <david@gibson.dropbear.id.au>
> 
> The new warnings in fwd_rule_add() have some not quite technically correct
> format specifiers.  For some weird reason these don't trip warnings on
> passt itself, but do when we re-use this code in the upcoming configuration
> client.  Fix them.
> 
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: Laurent Vivier <lvivier@redhat.com>

> ---
>   fwd_rule.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fwd_rule.c b/fwd_rule.c
> index 777282d..7fd20dd 100644
> --- a/fwd_rule.c
> +++ b/fwd_rule.c
> @@ -208,7 +208,7 @@ static int fwd_rule_add(struct fwd_table *fwd, const struct fwd_rule *new)
>   		return -EINVAL;
>   	}
>   	if (new->flags & ~allowed_flags) {
> -		warn("Rule has invalid flags 0x%hhx",
> +		warn("Rule has invalid flags 0x%x",
>   		     new->flags & ~allowed_flags);
>   		return -EINVAL;
>   	}
> @@ -267,11 +267,11 @@ static int fwd_rule_add(struct fwd_table *fwd, const struct fwd_rule *new)
>   	}
>   
>   	if (fwd->count >= ARRAY_SIZE(fwd->rules)) {
> -		warn("Too many rules (maximum %u)", ARRAY_SIZE(fwd->rules));
> +		warn("Too many rules (maximum %d)", ARRAY_SIZE(fwd->rules));
>   		return -ENOSPC;
>   	}
>   	if ((fwd->sock_count + num) > ARRAY_SIZE(fwd->socks)) {
> -		warn("Rules require too many listening sockets (maximum %u)",
> +		warn("Rules require too many listening sockets (maximum %d)",
>   		     ARRAY_SIZE(fwd->socks));
>   		return -ENOSPC;
>   	}