From: Paul Holzinger <pholzing@redhat.com>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] conf: Handle addresses passed via --dns just like the ones from resolv.conf
Date: Tue, 12 Mar 2024 11:20:01 +0100 [thread overview]
Message-ID: <f1995b66-d988-4190-b74d-7c7a6bcb2d52@redhat.com> (raw)
In-Reply-To: <20240312072136.225197-1-sbrivio@redhat.com>
On 12/03/2024 08:21, Stefano Brivio wrote:
> ...that is, call add_dns4() and add_dns6() instead of simply adding
> those to the list of servers we advertise.
>
> Most importantly, this will set the 'dns_host' field for the matching
> IP version, so that, as mentioned in the man page, servers passed via
> --dns are used for DNS mapping as well, if used in combination with
> --dns-forward.
>
> Reported-by: Paul Holzinger <pholzing@redhat.com>
> Link: https://bugs.passt.top/show_bug.cgi?id=82
> Fixes: 89678c515755 ("conf, udp: Introduce basic DNS forwarding")
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Tested-by: Paul Holzinger <pholzing@redhat.com>
next prev parent reply other threads:[~2024-03-12 10:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 7:21 [PATCH] conf: Handle addresses passed via --dns just like the ones from resolv.conf Stefano Brivio
2024-03-12 10:20 ` Paul Holzinger [this message]
2024-03-14 2:17 ` David Gibson
2024-03-14 4:54 ` Stefano Brivio
2024-03-14 5:08 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1995b66-d988-4190-b74d-7c7a6bcb2d52@redhat.com \
--to=pholzing@redhat.com \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).