public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: Jon Maloy <jmaloy@redhat.com>
Cc: david@gibson.dropbear.id.au, passt-dev@passt.top
Subject: Re: [PATCH v2 0/6] Fix issues and false positives from static analysis
Date: Thu, 16 Jul 2026 05:58:35 +0200 (CEST)	[thread overview]
Message-ID: <20260716055833.4abe008a@elisabeth> (raw)
In-Reply-To: <20260709215656.1351549-1-jmaloy@redhat.com>

On Thu,  9 Jul 2026 17:56:50 -0400
Jon Maloy <jmaloy@redhat.com> wrote:

> This series fixes minor issues found by static analysis tools in the
> main passt code and in documentation examples.
> 
> The core code changes add missing fd initialisations and guard unsigned
> arithmetic against potential underflow.
>                                        
> We also fix buffer handling, type mismatches, and resource leaks in
> the documentation example code.
> 
> v2: - udp_vu, tap: Use if-guards instead of assert(), to handle the
>       error paths properly and let the static checker follow the logic
>     - doc/migration: Use snprintf() instead of strncpy() for clarity
>       and guaranteed null-termination (David Gibson)
>     - Drop va_list initialisation patch (Stefano Brivio, David Gibson)   

Applied up to 2/6.

For the rest, I would rather wait for the discussion around 3/6 to come
to an end, also because I guess patches 4/6 to 6/6 aren't that much of
a priority. I haven't seen any other report of static checkers running
on documentation examples and actually it doesn't make a lot of sense
to me to do so.

-- 
Stefano


      parent reply	other threads:[~2026-07-16  3:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-09 21:56 Jon Maloy
2026-07-09 21:56 ` [PATCH v2 1/6] passt: Initialise listening socket fds to -1 Jon Maloy
2026-07-09 21:56 ` [PATCH v2 2/6] udp_vu: Check iov_tail_clone() return before assigning to msg_iovlen Jon Maloy
2026-07-10  1:32   ` David Gibson
2026-07-09 21:56 ` [PATCH v2 3/6] tap: Guard IPv6 tail size subtraction against underflow Jon Maloy
2026-07-10  1:36   ` David Gibson
2026-07-10 13:40     ` Jon Maloy
2026-07-13  4:09       ` David Gibson
2026-07-13 10:17         ` Jon Maloy
2026-07-14  0:00           ` David Gibson
2026-07-09 21:56 ` [PATCH v2 4/6] doc/migration: Use snprintf() for socket path and fix argv access Jon Maloy
2026-07-10  1:37   ` David Gibson
2026-07-09 21:56 ` [PATCH v2 5/6] doc/migration: Fix buffer type mismatch in recv() call Jon Maloy
2026-07-09 21:56 ` [PATCH v2 6/6] doc/platform-requirements: Close leaked sockets in test_close_dup() Jon Maloy
2026-07-16  3:58 ` Stefano Brivio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260716055833.4abe008a@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=jmaloy@redhat.com \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).