public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Anshu Kumari <anskuma@redhat.com>
To: passt-dev@passt.top, sbrivio@redhat.com, ada.urbaniec+bugzilla@gmail.com
Cc: anskuma@redhat.com
Subject: [PATCH v3] tcp: Limit fast retransmit to one per loss event
Date: Fri, 20 Nov 2026 23:07:56 +0530	[thread overview]
Message-ID: <20261120173756.2000624-1-anskuma@redhat.com> (raw)

Every duplicate ACK unconditionally triggered a fast retransmit,
even when the ACK sequence hadn't advanced.

Guard fast retransmit on !conn->retries, and increment retries
after the first retransmit. This is a quick fix to stop the
amplification storm. Full compliance with RFC 5681 Section 3.2
(three duplicate ACKs) is left to a later patch.

Link: https://bugs.passt.top/show_bug.cgi?id=224
Signed-off-by: Anshu Kumari <anskuma@redhat.com>
---
 tcp.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tcp.c b/tcp.c
index 95f4f3e1..d3d65f76 100644
--- a/tcp.c
+++ b/tcp.c
@@ -2082,7 +2082,9 @@ static int tcp_data_from_tap(const struct ctx *c, struct tcp_tap_conn *conn,
 
 	tcp_tap_window_update(c, conn, max_ack_seq_wnd, now);
 
-	if (retr) {
+	if (retr && !conn->retries) {
+		conn->retries++;
+
 		flow_trace(conn,
 			   "fast re-transmit, ACK: %u, previous sequence: %u",
 			   conn->seq_ack_from_tap, conn->seq_to_tap);
@@ -2443,7 +2445,9 @@ int tcp_tap_handler(const struct ctx *c, uint8_t pif, sa_family_t af,
 			tcp_update_seqack_from_tap(c, conn, ntohl(th->ack_seq),
 						   now);
 
-		if (retr) {
+		if (retr && !conn->retries) {
+			conn->retries++;
+
 			flow_trace(conn,
 				   "fast re-transmit, ACK: %u, previous sequence: %u",
 				   ntohl(th->ack_seq), conn->seq_to_tap);
-- 
2.55.0


             reply	other threads:[~2026-11-20 17:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 17:37 Anshu Kumari [this message]
2026-11-20 19:48 ` Jon Maloy
2026-11-20 20:18 ` Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120173756.2000624-1-anskuma@redhat.com \
    --to=anskuma@redhat.com \
    --cc=ada.urbaniec+bugzilla@gmail.com \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).