From: Stefano Brivio <sbrivio@redhat.com>
To: ada.urbaniec+bugzilla@gmail.com
Cc: Anshu Kumari <anskuma@redhat.com>, passt-dev@passt.top
Subject: Re: [PATCH v3] tcp: Limit fast retransmit to one per loss event
Date: Fri, 20 Nov 2026 21:18:34 +0100 (CET) [thread overview]
Message-ID: <20261120211833.656426f0@elisabeth> (raw)
In-Reply-To: <20261120173756.2000624-1-anskuma@redhat.com>
On Fri, 20 Nov 2026 23:07:56 +0530
Anshu Kumari <anskuma@redhat.com> wrote:
> Every duplicate ACK unconditionally triggered a fast retransmit,
> even when the ACK sequence hadn't advanced.
>
> Guard fast retransmit on !conn->retries, and increment retries
> after the first retransmit. This is a quick fix to stop the
> amplification storm. Full compliance with RFC 5681 Section 3.2
> (three duplicate ACKs) is left to a later patch.
Ada, would you have a chance to try this patch out? Would you like to
be credited with a Reported-by: tag?
--
Stefano
prev parent reply other threads:[~2026-11-20 20:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 17:37 Anshu Kumari
2026-11-20 19:48 ` Jon Maloy
2026-11-20 20:18 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120211833.656426f0@elisabeth \
--to=sbrivio@redhat.com \
--cc=ada.urbaniec+bugzilla@gmail.com \
--cc=anskuma@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).