public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject: Re: [PATCH 1/2] test/perf: Check for /sbin/sysctl with which(1), not simply sysctl
Date: Sat, 17 Sep 2022 13:27:32 +1000	[thread overview]
Message-ID: <YyU+pOz9x7s6ogsv@yekko> (raw)
In-Reply-To: <20220916235534.2399997-2-sbrivio@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 2593 bytes --]

On Sat, Sep 17, 2022 at 01:55:33AM +0200, Stefano Brivio wrote:
> Otherwise, we're depending on having /sbin in $PATH. For some reason

Huh.  I wonder why this is working for me.

> I didn't completely grasp, with the new command dispatch mechanism
> that's not the case anymore, even if I have /sbin in $PATH in the
> parent shell.

For the guest, there's no mystery - there's no strong connection
between the shell environments there.  We probably can control PATH
with our mbuto setup though.

For the ns that is strange, though.

> 
> Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>
> ---
>  test/perf/passt_tcp | 4 ++--
>  test/perf/passt_udp | 2 +-
>  test/perf/pasta_tcp | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/test/perf/passt_tcp b/test/perf/passt_tcp
> index 45095b6..f0cfa1b 100644
> --- a/test/perf/passt_tcp
> +++ b/test/perf/passt_tcp
> @@ -11,8 +11,8 @@
>  # Copyright (c) 2021 Red Hat GmbH
>  # Author: Stefano Brivio <sbrivio(a)redhat.com>
>  
> -gtools	sysctl ip jq nproc seq sleep iperf3 tcp_rr tcp_crr # From neper
> -nstools	sysctl ip jq nproc seq sleep iperf3 tcp_rr tcp_crr
> +gtools	/sbin/sysctl ip jq nproc seq sleep iperf3 tcp_rr tcp_crr # From neper
> +nstools	/sbin/sysctl ip jq nproc seq sleep iperf3 tcp_rr tcp_crr
>  htools	bc head sed seq
>  
>  # In this setup, virtio_net TX queue sometimes hangs, still under investigation
> diff --git a/test/perf/passt_udp b/test/perf/passt_udp
> index d199523..80731d1 100644
> --- a/test/perf/passt_udp
> +++ b/test/perf/passt_udp
> @@ -11,7 +11,7 @@
>  # Copyright (c) 2021 Red Hat GmbH
>  # Author: Stefano Brivio <sbrivio(a)redhat.com>
>  
> -gtools	sysctl ip jq nproc sleep iperf3 udp_rr # From neper
> +gtools	/sbin/sysctl ip jq nproc sleep iperf3 udp_rr # From neper
>  nstools	ip jq sleep iperf3 udp_rr
>  htools	bc head sed
>  
> diff --git a/test/perf/pasta_tcp b/test/perf/pasta_tcp
> index 4c19364..602ce52 100644
> --- a/test/perf/pasta_tcp
> +++ b/test/perf/pasta_tcp
> @@ -12,7 +12,7 @@
>  # Author: Stefano Brivio <sbrivio(a)redhat.com>
>  
>  htools	head ip seq bc sleep iperf3 tcp_rr tcp_crr jq sed
> -nstools	sysctl nproc ip seq sleep iperf3 tcp_rr tcp_crr jq sed
> +nstools	/sbin/sysctl nproc ip seq sleep iperf3 tcp_rr tcp_crr jq sed
>  
>  test	pasta: throughput and latency (local connections)
>  

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2022-09-17  3:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-16 23:55 [PATCH 0/2] test: Fix two issues made apparent by new command dispatch Stefano Brivio
2022-09-16 23:55 ` [PATCH 1/2] test/perf: Check for /sbin/sysctl with which(1), not simply sysctl Stefano Brivio
2022-09-17  3:27   ` David Gibson [this message]
2022-09-17  8:44     ` Stefano Brivio
2022-09-17  9:51       ` David Gibson
2022-09-16 23:55 ` [PATCH 2/2] test/passt_in_ns: Consistent sleep commands before starting socat client Stefano Brivio
2022-09-17  3:32   ` David Gibson
2022-09-17  8:44     ` Stefano Brivio
2022-09-17 10:19       ` David Gibson
2022-09-17 11:28         ` Stefano Brivio
2022-09-19  1:48           ` David Gibson
2022-09-19  6:41             ` Stefano Brivio
2022-09-19  7:00               ` David Gibson
2022-09-19  8:24                 ` Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YyU+pOz9x7s6ogsv@yekko \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).