[PATCH] tcp, udp: Allow timerfd_gettime64() and recvmmsg_time64() on arm (armhf)

[PATCH] tcp, udp: Allow timerfd_gettime64() and recvmmsg_time64() on arm (armhf)

[Stefano Brivio]

These system calls are needed after the conversion of time_t to 64-bit
types on 32-bit architectures.

Tested by running some transfer tests with passt and pasta on Debian
Bookworm (glibc 2.36) and Trixie (glibc 2.39), running on armv6l.

Suggested-by: Faidon Liambotis <paravoid@debian.org>
Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1078981
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
 tcp.c | 2 +-
 udp.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tcp.c b/tcp.c
index c542a78..501c56c 100644
--- a/tcp.c
+++ b/tcp.c
@@ -2143,7 +2143,7 @@ cancel:
  * @c:		Execution context
  * @ref:	epoll reference of timer (not connection)
  *
- * #syscalls timerfd_gettime i686:timerfd_gettime64
+ * #syscalls timerfd_gettime arm:timerfd_gettime64 i686:timerfd_gettime64
  */
 void tcp_timer_handler(struct ctx *c, union epoll_ref ref)
 {
diff --git a/udp.c b/udp.c
index 851881e..f8fd597 100644
--- a/udp.c
+++ b/udp.c
@@ -460,7 +460,7 @@ static bool udp_sock_recverr(int s)
  * @events:	epoll events bitmap
  * @mmh		mmsghdr array to receive into
  *
- * #syscalls recvmmsg i686:recvmmsg_time64
+ * #syscalls recvmmsg arm:recvmmsg_time64 i686:recvmmsg_time64
  */
 static int udp_sock_recv(const struct ctx *c, int s, uint32_t events,
 			 struct mmsghdr *mmh)
-- 
@@ -460,7 +460,7 @@ static bool udp_sock_recverr(int s)
  * @events:	epoll events bitmap
  * @mmh		mmsghdr array to receive into
  *
- * #syscalls recvmmsg i686:recvmmsg_time64
+ * #syscalls recvmmsg arm:recvmmsg_time64 i686:recvmmsg_time64
  */
 static int udp_sock_recv(const struct ctx *c, int s, uint32_t events,
 			 struct mmsghdr *mmh)
-- 
2.43.0

Re: [PATCH] tcp, udp: Allow timerfd_gettime64() and recvmmsg_time64() on arm (armhf)

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 1748 bytes --]

On Tue, Aug 20, 2024 at 01:15:29AM +0200, Stefano Brivio wrote:
> These system calls are needed after the conversion of time_t to 64-bit
> types on 32-bit architectures.
> 
> Tested by running some transfer tests with passt and pasta on Debian
> Bookworm (glibc 2.36) and Trixie (glibc 2.39), running on armv6l.
> 
> Suggested-by: Faidon Liambotis <paravoid@debian.org>
> Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1078981
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  tcp.c | 2 +-
>  udp.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tcp.c b/tcp.c
> index c542a78..501c56c 100644
> --- a/tcp.c
> +++ b/tcp.c
> @@ -2143,7 +2143,7 @@ cancel:
>   * @c:		Execution context
>   * @ref:	epoll reference of timer (not connection)
>   *
> - * #syscalls timerfd_gettime i686:timerfd_gettime64
> + * #syscalls timerfd_gettime arm:timerfd_gettime64 i686:timerfd_gettime64
>   */
>  void tcp_timer_handler(struct ctx *c, union epoll_ref ref)
>  {
> diff --git a/udp.c b/udp.c
> index 851881e..f8fd597 100644
> --- a/udp.c
> +++ b/udp.c
> @@ -460,7 +460,7 @@ static bool udp_sock_recverr(int s)
>   * @events:	epoll events bitmap
>   * @mmh		mmsghdr array to receive into
>   *
> - * #syscalls recvmmsg i686:recvmmsg_time64
> + * #syscalls recvmmsg arm:recvmmsg_time64 i686:recvmmsg_time64
>   */
>  static int udp_sock_recv(const struct ctx *c, int s, uint32_t events,
>  			 struct mmsghdr *mmh)

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]