Re: [PATCH 0/4] Assorted minor socket creation cleanups

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 2361 bytes --]

On Fri, Jun 12, 2026 at 01:05:17AM +0200, Stefano Brivio wrote:
> On Tue,  9 Jun 2026 16:30:01 +1000
> David Gibson <david@gibson.dropbear.id.au> wrote:
> 
> > As discussed on our recent call, I was looking again at bug 167.  I
> > discovered it's still fairly fiddly to address this, but while
> > investigating spotted a number of cleanups to make in the vicinity.  I
> > think they make sense even without fixing bug 167 (yet), so here they
> > are.
> > 
> > David Gibson (4):
> >   flow: Correct misleading signature of flowside_sock_l4()
> >   Makefile: Remove unused DUAL_STACK_SOCKETS define
> >   fwd, pif: Remove duplicated logic between tcp_listen() and
> >     udp_listen()
> >   pif, util: Move listen(2) call from sock_l4_() to pif_listen()
> 
> I was about to apply this (there are no apparent conflicts with "[PATCH
> 0/4] RFC: Improvements to flow specific logging", which I still need to
> review), but cppcheck now says:
> 
> ---
> flow.c:216:31: style: inconclusive: Function 'flowside_sock_l4' argument 4 names different: declaration 'tgt' definition 'side'. [funcArgNamesDifferent]
>        const struct flowside *side)
>                               ^
> flow.h:176:31: note: Function 'flowside_sock_l4' argument 4 names different: declaration 'tgt' definition 'side'.
>        const struct flowside *tgt);
>                               ^
> flow.c:216:31: note: Function 'flowside_sock_l4' argument 4 names different: declaration 'tgt' definition 'side'.
>        const struct flowside *side)
>                               ^
> pif.c:111:10: error: Overlapping read/write of union is undefined behavior [overlappingWriteUnion]
>   ref.fd = sock_l4_dualstack_any(c, ref.type, port, ifname);
>          ^
> pif.c:116:10: error: Overlapping read/write of union is undefined behavior [overlappingWriteUnion]
>   ref.fd = sock_l4(c, ref.type, &sa, ifname);
>          ^
> ---

Bother.  I thought I'd done a cppcheck / clang-tidy pass, but
apparently I missed it :(.

> ...is it just my version (2.19.0)?

No.  Although my version (2.21.0) also gives some new errors on the
main branch.  Hang on..

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]