From: Martin Schitter <ms+git@mur.at>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH v2 2/3] Timekeeping: Resolving Route Dependencies
Date: Sat, 19 Sep 2026 14:56:46 +0200 [thread overview]
Message-ID: <bfa24a55-4676-4aa6-a0bc-a0b1d249b8b1@mur.at> (raw)
In-Reply-To: <20260917210818.4900083a@elisabeth>
On 9/17/26 21:08, Stefano Brivio wrote:
>> + clock_gettime(CLOCK_MONOTONIC, &now);
>> + debug("route dependency handling time: %f s",
>> + (now.tv_sec - start.tv_sec) + (now.tv_nsec - start.tv_nsec)/1.0e9);
>
> And anyway, I'm not sure I see the value of this. Which other functions
> should we profile? Does it help at all to do this once you're done
> developing it?
>
> I would suggest to simply drop this patch. I understand you needed that
> for development but you already explain in the commit message for 3/3
> how it improves thing, and that's all the documentation we possibly
> need for the future, I think.
For this reason I placed these profiling related changes in a separate
patch. They can be easily ignored.
Nevertheless, it's still very important to optimize and profile the
actual handling of huge routing tables. The original implementation was
really horrible in this regard.
next prev parent reply other threads:[~2026-09-19 12:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 18:13 [PATCH v2] Fix for Bug #221 -- Issue concerning bigger routing tables Martin Schitter
2026-09-08 18:13 ` [PATCH v2 1/3] Fix handling of netlink multipart route dumps Martin Schitter
2026-09-17 19:08 ` Stefano Brivio
2026-09-19 12:56 ` Martin Schitter
2026-09-08 18:13 ` [PATCH v2 2/3] Timekeeping: Resolving Route Dependencies Martin Schitter
2026-09-17 19:08 ` Stefano Brivio
2026-09-19 12:56 ` Martin Schitter [this message]
2026-09-08 18:13 ` [PATCH v2 3/3] Optimize route dependency solver Martin Schitter
2026-09-17 19:08 ` Stefano Brivio
2026-09-19 12:56 ` Martin Schitter
2026-09-19 13:07 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfa24a55-4676-4aa6-a0bc-a0b1d249b8b1@mur.at \
--to=ms+git@mur.at \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).