From: Laurent Vivier <lvivier@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>,
Stefano Brivio <sbrivio@redhat.com>,
passt-dev@passt.top
Subject: Re: [PATCH 1/5] clangd: Add _GNU_SOURCE to default clangd options
Date: Fri, 21 Aug 2026 14:50:37 +0200 [thread overview]
Message-ID: <1176c9e6-eda5-4803-82ff-bcc83a2fda5d@redhat.com> (raw)
In-Reply-To: <20260821050403.170891-2-david@gibson.dropbear.id.au>
On 8/21/26 07:03, David Gibson wrote:
> We always insert -D_GNU_SOURCE and -D_XOPEN_SOURCE=700 when compiling from
> the Makefile, and we rely on it. Without these listed in .clangd, clangd
> will generate numerous spurious warnings.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> .clangd | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.clangd b/.clangd
> index 41bec92a..51baf737 100644
> --- a/.clangd
> +++ b/.clangd
> @@ -1,3 +1,3 @@
> CompileFlags:
> # Don't try to interpret our headers as C++'
> - Add: [-xc, -Wall]
> + Add: [-xc, -Wall, -D_XOPEN_SOURCE=700, -D_GNU_SOURCE]
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
next prev parent reply other threads:[~2026-08-21 12:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 5:03 [PATCH 0/5] Settings for Zed editor and minor fixups David Gibson
2026-08-21 5:03 ` [PATCH 1/5] clangd: Add _GNU_SOURCE to default clangd options David Gibson
2026-08-21 12:50 ` Laurent Vivier [this message]
2026-08-21 5:04 ` [PATCH 2/5] util: Eliminate a stray trailing whitespace David Gibson
2026-08-21 12:52 ` Laurent Vivier
2026-08-21 5:04 ` [PATCH 3/5] util: Add missing O_CLOEXEC for !HAS_GETRANDOM path David Gibson
2026-08-21 12:56 ` Laurent Vivier
2026-08-21 5:04 ` [PATCH 4/5] util, pasta: Remove some unneeded #includes David Gibson
2026-08-21 13:05 ` Laurent Vivier
2026-08-21 5:04 ` [PATCH 5/5] Add Zed editor settings David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1176c9e6-eda5-4803-82ff-bcc83a2fda5d@redhat.com \
--to=lvivier@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).