From: Laurent Vivier <lvivier@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>,
Stefano Brivio <sbrivio@redhat.com>,
passt-dev@passt.top
Subject: Re: [PATCH 4/5] util, pasta: Remove some unneeded #includes
Date: Fri, 21 Aug 2026 15:05:00 +0200 [thread overview]
Message-ID: <3e540fa0-101b-4de5-9574-e8f7c9270623@redhat.com> (raw)
In-Reply-To: <20260821050403.170891-5-david@gibson.dropbear.id.au>
On 8/21/26 07:04, David Gibson wrote:
> Presumably these mattered at some point in the past, but no longer. Found
> by clangd as invoked by Zed editor. Not sure why direct clang-tidy runs
> didn't spot these.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> pasta.c | 1 -
> util.c | 3 ---
> 2 files changed, 4 deletions(-)
>
> diff --git a/pasta.c b/pasta.c
> index 5aa56b78..247ebeda 100644
> --- a/pasta.c
> +++ b/pasta.c
> @@ -46,7 +46,6 @@
>
> #include "util.h"
> #include "passt.h"
> -#include "isolation.h"
> #include "netlink.h"
> #include "log.h"
> #include "epoll_ctl.h"
> diff --git a/util.c b/util.c
> index df972a05..99585d2c 100644
> --- a/util.c
> +++ b/util.c
> @@ -30,11 +30,8 @@
> #include "util.h"
> #include "iov.h"
> #include "passt.h"
> -#include "packet.h"
> #include "log.h"
> #include "pcap.h"
> -#include "epoll_ctl.h"
> -#include "pasta.h"
> #include "serialise.h"
> #ifdef HAS_GETRANDOM
> #include <sys/random.h>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
next prev parent reply other threads:[~2026-08-21 13:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 5:03 [PATCH 0/5] Settings for Zed editor and minor fixups David Gibson
2026-08-21 5:03 ` [PATCH 1/5] clangd: Add _GNU_SOURCE to default clangd options David Gibson
2026-08-21 12:50 ` Laurent Vivier
2026-08-21 5:04 ` [PATCH 2/5] util: Eliminate a stray trailing whitespace David Gibson
2026-08-21 12:52 ` Laurent Vivier
2026-08-21 5:04 ` [PATCH 3/5] util: Add missing O_CLOEXEC for !HAS_GETRANDOM path David Gibson
2026-08-21 12:56 ` Laurent Vivier
2026-08-21 5:04 ` [PATCH 4/5] util, pasta: Remove some unneeded #includes David Gibson
2026-08-21 13:05 ` Laurent Vivier [this message]
2026-08-21 5:04 ` [PATCH 5/5] Add Zed editor settings David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e540fa0-101b-4de5-9574-e8f7c9270623@redhat.com \
--to=lvivier@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).