From: Laurent Vivier <lvivier@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>,
Stefano Brivio <sbrivio@redhat.com>,
passt-dev@passt.top
Subject: Re: [PATCH 3/5] util: Add missing O_CLOEXEC for !HAS_GETRANDOM path
Date: Fri, 21 Aug 2026 14:56:31 +0200 [thread overview]
Message-ID: <63544f72-d8b4-4cc7-9975-3ecb318ae984@redhat.com> (raw)
In-Reply-To: <20260821050403.170891-4-david@gibson.dropbear.id.au>
On 8/21/26 07:04, David Gibson wrote:
> It rarely matters, since we usually have getrandom(), but in case we don't
> our open() of /dev/random was missing O_CLOEXEC, which can cause clang
> warnings.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> util.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util.c b/util.c
> index 500e8f55..df972a05 100644
> --- a/util.c
> +++ b/util.c
> @@ -964,7 +964,7 @@ void raw_random(void *buf, size_t buflen)
> {
> size_t random_read = 0;
> #ifndef HAS_GETRANDOM
> - int fd = open(DEV_RANDOM, O_RDONLY);
> + int fd = open(DEV_RANDOM, O_RDONLY | O_CLOEXEC);
>
> if (fd < 0)
> die_perror("Couldn't open %s", DEV_RANDOM);
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
next prev parent reply other threads:[~2026-08-21 12:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 5:03 [PATCH 0/5] Settings for Zed editor and minor fixups David Gibson
2026-08-21 5:03 ` [PATCH 1/5] clangd: Add _GNU_SOURCE to default clangd options David Gibson
2026-08-21 12:50 ` Laurent Vivier
2026-08-21 5:04 ` [PATCH 2/5] util: Eliminate a stray trailing whitespace David Gibson
2026-08-21 12:52 ` Laurent Vivier
2026-08-21 5:04 ` [PATCH 3/5] util: Add missing O_CLOEXEC for !HAS_GETRANDOM path David Gibson
2026-08-21 12:56 ` Laurent Vivier [this message]
2026-08-21 5:04 ` [PATCH 4/5] util, pasta: Remove some unneeded #includes David Gibson
2026-08-21 13:05 ` Laurent Vivier
2026-08-21 5:04 ` [PATCH 5/5] Add Zed editor settings David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63544f72-d8b4-4cc7-9975-3ecb318ae984@redhat.com \
--to=lvivier@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).