From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH v2 13/13] qrap: Run static checkers
Date: Tue, 28 Apr 2026 09:17:38 +0200 (CEST) [thread overview]
Message-ID: <20260428091736.5239794b@elisabeth> (raw)
In-Reply-To: <20260421032338.1909084-14-david@gibson.dropbear.id.au>
On Tue, 21 Apr 2026 13:23:38 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:
> Run the static checkers on qrap as well as on passt-repair and passt. This
> shows a number of minor warnings, which we fix.
This is actually for qrap only, so I would drop it. See also
8346216c9adf ("Makefile: Simplify exclusion of qrap from static checks") and
988a4d75f894 ("Makefile: Exclude qrap.c from clang-tidy checks")
It's not really something we maintain and the next commit touching qrap
should really remove the whole thing instead. The "soon" in
988a4d75f894 was almost two years ago.
My worry is that if we enable static checkers here we risk having to
waste time on warnings in the near future.
Other than this and the comment to 4/13 the series looks good to me,
and I'm basing v6 of "RFC: Dynamic configuration update implementation"
on it.
--
Stefano
next prev parent reply other threads:[~2026-04-28 7:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 3:23 [PATCH v2 00/13] Improvements to static checker invocation David Gibson
2026-04-21 3:23 ` [PATCH v2 01/13] Makefile: Use make variables for static checker configuration David Gibson
2026-04-21 3:23 ` [PATCH v2 02/13] cppcheck: Split out essential defines into a BASE_CPPFLAGS variable David Gibson
2026-04-21 3:23 ` [PATCH v2 03/13] Makefile: Remove preprocessor flags from $(FLAGS) David Gibson
2026-04-21 3:23 ` [PATCH v2 04/13] Makefile: Remove non-standard $(FLAGS) variable David Gibson
2026-04-28 7:17 ` Stefano Brivio
2026-04-29 3:47 ` David Gibson
2026-04-29 5:01 ` David Gibson
2026-04-21 3:23 ` [PATCH v2 05/13] Makefile: Make conditional definition of $(BIN) clearer David Gibson
2026-04-21 3:23 ` [PATCH v2 06/13] Makefile: Use common binary compilation rule David Gibson
2026-04-21 3:23 ` [PATCH v2 07/13] Makefile: Remove unhelpful $(HEADERS) variable David Gibson
2026-04-21 3:23 ` [PATCH v2 08/13] Makefile: Add header dependencies for secondary binaries David Gibson
2026-04-21 3:23 ` [PATCH v2 09/13] Makefile: Split static checker targets David Gibson
2026-04-21 3:23 ` [PATCH v2 10/13] passt-repair: Split out inotify handling to its own function David Gibson
2026-04-21 3:23 ` [PATCH v2 11/13] passt-repair: Simplify construction of Unix path from inotify David Gibson
2026-04-21 3:23 ` [PATCH v2 12/13] passt-repair: Run static checkers David Gibson
2026-04-21 3:23 ` [PATCH v2 13/13] qrap: " David Gibson
2026-04-28 7:17 ` Stefano Brivio [this message]
2026-04-29 3:48 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260428091736.5239794b@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).