public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 8/8] clang-tidy: Suppress some new unhelpful new warnings
Date: Mon, 11 May 2026 20:03:22 +1000	[thread overview]
Message-ID: <20260511100322.1016757-9-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20260511100322.1016757-1-david@gibson.dropbear.id.au>

clang-tidy 22.1.4 (or thereabouts) introduced some new warning categories
that while theoretically useful, trip in too many silly occasions to be
useful.  Suppress them.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 .clang-tidy | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/.clang-tidy b/.clang-tidy
index 773121f5..9ba43bf0 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -86,6 +86,17 @@ Checks:
     # #if directives.  Don't insist on #ifdef instead.
     - "-readability-use-concise-preprocessor-directives"
 
+    # clang-tidy, at least version 22.1.4 seems to generate a heap of
+    # false positives for this warning, asking us to make things
+    # static that are already used in other modules.
+    - "-misc-use-internal-linkage"
+
+    # Warning about bool/int conversions could sometimes be useful.
+    # Unfortunately (as of clang-tidy 22.1.4) it warns in some really
+    # dumb situations, like not allowing !, && etc. on bool inputs to
+    # be treated directly as a bool.
+    - "-readability-implicit-bool-conversion"
+
 WarningsAsErrors: "*"
 HeaderFileExtensions:
     - h
-- 
2.54.0


  parent reply	other threads:[~2026-05-11 10:03 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11 10:03 [PATCH 0/8] Fix assorted warnings David Gibson
2026-05-11 10:03 ` [PATCH 1/8] netlink: erromsg should be const in nl_status() David Gibson
2026-05-11 12:50   ` Laurent Vivier
2026-05-11 10:03 ` [PATCH 2/8] virtio: Reduce scope of variable David Gibson
2026-05-11 12:51   ` Laurent Vivier
2026-05-11 10:03 ` [PATCH 3/8] conf: Fix not-actually-const parameter to conf_runas() and conf_ugid() David Gibson
2026-05-11 13:00   ` Laurent Vivier
2026-05-11 10:03 ` [PATCH 4/8] clang-tidy: Squash inconsistent brace warnings in foreach macros David Gibson
2026-05-11 13:21   ` Laurent Vivier
2026-05-11 10:03 ` [PATCH 5/8] clang-tidy: Suppress sscanf() warning harder David Gibson
2026-05-11 13:23   ` Laurent Vivier
2026-05-11 10:03 ` [PATCH 6/8] packet, clang-tidy: Packet pool buffers are not NULL David Gibson
2026-05-11 13:27   ` Laurent Vivier
2026-05-11 10:03 ` [PATCH 7/8] treewide: Make some additional variables static David Gibson
2026-05-11 13:30   ` Laurent Vivier
2026-05-11 10:03 ` David Gibson [this message]
2026-05-11 13:32   ` [PATCH 8/8] clang-tidy: Suppress some new unhelpful new warnings Laurent Vivier
2026-05-12  5:45 ` [PATCH 0/8] Fix assorted warnings Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260511100322.1016757-9-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).