Re: [PATCH 8/8] clang-tidy: Suppress some new unhelpful new warnings

[Laurent Vivier <lvivier@redhat.com>]

On 5/11/26 12:03, David Gibson wrote:
> clang-tidy 22.1.4 (or thereabouts) introduced some new warning categories
> that while theoretically useful, trip in too many silly occasions to be
> useful.  Suppress them.
> 
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

Reviewed-by: Laurent Vivier <lvivier@redhat.com>

> ---
>   .clang-tidy | 11 +++++++++++
>   1 file changed, 11 insertions(+)
> 
> diff --git a/.clang-tidy b/.clang-tidy
> index 773121f5..9ba43bf0 100644
> --- a/.clang-tidy
> +++ b/.clang-tidy
> @@ -86,6 +86,17 @@ Checks:
>       # #if directives.  Don't insist on #ifdef instead.
>       - "-readability-use-concise-preprocessor-directives"
>   
> +    # clang-tidy, at least version 22.1.4 seems to generate a heap of
> +    # false positives for this warning, asking us to make things
> +    # static that are already used in other modules.
> +    - "-misc-use-internal-linkage"
> +
> +    # Warning about bool/int conversions could sometimes be useful.
> +    # Unfortunately (as of clang-tidy 22.1.4) it warns in some really
> +    # dumb situations, like not allowing !, && etc. on bool inputs to
> +    # be treated directly as a bool.
> +    - "-readability-implicit-bool-conversion"
> +
>   WarningsAsErrors: "*"
>   HeaderFileExtensions:
>       - h